forked from bgd-labs/aave-proposals-v3
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to proposal for Gho Incident Report 20231113 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Foundry report forge 0.2.0 (fdad9fb 2023-12-06T00:17:27.061170607Z) Build logCompiling 291 files with 0.8.19
Solc 0.8.19 finished in 156.34s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
--> lib/aave-helpers/src/GovV3Helpers.sol:775:5:
|
775 | address votingPortal
| ^^^^^^^^^^^^^^^^^^^^
Warning (2072): Unused local variable.
--> src/20231122_AaveV3Harmony_FreezePriceFeedsOnV3Harmony/FreezePriceFeedsOnV3Harmony_20231122.s.sol:16:5:
|
16 | AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122 payload0 = new AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| Contract | Size (kB) | Margin (kB) |
|-----------------------------------------------------------------------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.086 | 24.49 |
| AaveSafetyModule | 0.086 | 24.49 |
| AaveSwapper | 5.613 | 18.963 |
| AaveV1Ethereum_FixedREPPriceFeed_20231031 | 0.706 | 23.87 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2AvalancheAssets | 0.086 | 24.49 |
| AaveV2Avalanche_IncreaseStablecoinOptimalBorrowRates_20231113 | 1.899 | 22.677 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumAMMAssets | 0.086 | 24.49 |
| AaveV2EthereumAssets | 0.086 | 24.49 |
| AaveV2Ethereum_AaveV2EthereumLTReduction_20231030 | 3.023 | 21.553 |
| AaveV2Ethereum_Disable_Stable_Borrows_20231104 | 2.519 | 22.057 |
| AaveV2Ethereum_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.078 | 21.498 |
| AaveV2Ethereum_V2DeprecationPlan20231120_20231121 | 2.003 | 22.573 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV2PolygonAssets | 0.086 | 24.49 |
| AaveV2Polygon_AaveFundingUpdates_20231102 | 1.627 | 22.949 |
| AaveV2Polygon_IncreaseStablecoinOptimalBorrowRates_20231113 | 1.899 | 22.677 |
| AaveV2Polygon_ReserveFactorUpdatesPolygonAaveV2_20231103 | 1.01 | 23.566 |
| AaveV2Polygon_ReserveFactorUpdatesPolygonAaveV2_20231124 | 1.01 | 23.566 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumAssets | 0.086 | 24.49 |
| AaveV3ArbitrumEModes | 0.086 | 24.49 |
| AaveV3Arbitrum_Disable_Stable_Borrows_20231104 | 4.14 | 20.436 |
| AaveV3Arbitrum_IncreaseStablecoinOptimalBorrowRates_20231113 | 5.167 | 19.409 |
| AaveV3Arbitrum_MAIMIMATICDeprecation20231031_20231031 | 4.227 | 20.349 |
| AaveV3Arbitrum_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3AvalancheAssets | 0.086 | 24.49 |
| AaveV3AvalancheEModes | 0.086 | 24.49 |
| AaveV3Avalanche_Disable_Stable_Borrows_20231104 | 3.471 | 21.105 |
| AaveV3Avalanche_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.665 | 19.911 |
| AaveV3Avalanche_MAIMIMATICDeprecation20231031_20231031 | 4.364 | 20.212 |
| AaveV3Base | 0.086 | 24.49 |
| AaveV3BaseAssets | 0.086 | 24.49 |
| AaveV3BaseEModes | 0.086 | 24.49 |
| AaveV3Base_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.667 | 20.909 |
| AaveV3Base_OnboardingWstETHToAaveV3OnBaseNetwork_20231127 | 5.044 | 19.532 |
| AaveV3Base_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Ethereum | 0.086 | 24.49 |
| AaveV3EthereumAssets | 0.086 | 24.49 |
| AaveV3EthereumEModes | 0.086 | 24.49 |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682 | 23.894 |
| AaveV3Ethereum_AaveFundingUpdates_20231102 | 5.809 | 18.767 |
| AaveV3Ethereum_AddFXSToEthereumV3_20231108 | 4.996 | 19.58 |
| AaveV3Ethereum_AmendSafetyModuleAAVEEmissions_20231104 | 1.938 | 22.638 |
| AaveV3Ethereum_CRVUSDOnboardingOnAaveV3Ethereum_20231116 | 4.996 | 19.58 |
| AaveV3Ethereum_ChaosLabsRiskManagementRenewal_20231101 | 1.014 | 23.562 |
| AaveV3Ethereum_ChaosLabsRiskParameterUpdatesIncreaseMKRDebtCeilingOnV3Ethereum_20231116 | 3.418 | 21.158 |
| AaveV3Ethereum_GHOIncreaseBorrowRate_20231108 | 0.326 | 24.25 |
| AaveV3Ethereum_GHO_Incident_Report_20231122 | 0.385 | 24.191 |
| AaveV3Ethereum_GauntletAaveRenewal2023_20231128 | 1.232 | 23.344 |
| AaveV3Ethereum_GhoIncidentReport_20231113 | 1.098 | 23.478 |
| AaveV3Ethereum_IncreaseGHOBorrowRate_20231121 | 0.326 | 24.25 |
| AaveV3Ethereum_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.417 | 20.159 |
| AaveV3Ethereum_TokenLogicFunding_20231114 | 0.423 | 24.153 |
| AaveV3Ethereum_TreasuryManagementAddToRETHHolding_20231103 | 1.928 | 22.648 |
| AaveV3Ethereum_UpgradeAaveV3ETHPooolWETHParameters_20231031 | 3.671 | 20.905 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomAssets | 0.086 | 24.49 |
| AaveV3FantomEModes | 0.086 | 24.49 |
| AaveV3Gnosis | 0.086 | 24.49 |
| AaveV3GnosisAssets | 0.086 | 24.49 |
| AaveV3GnosisEModes | 0.086 | 24.49 |
| AaveV3Gnosis_AaveV3GnosisActivation_20231026 | 8.802 | 15.774 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3HarmonyAssets | 0.086 | 24.49 |
| AaveV3HarmonyEModes | 0.086 | 24.49 |
| AaveV3Harmony_FreezePriceFeedsOnV3Harmony_20231122 | 3.097 | 21.479 |
| AaveV3Metis | 0.086 | 24.49 |
| AaveV3MetisAssets | 0.086 | 24.49 |
| AaveV3MetisEModes | 0.086 | 24.49 |
| AaveV3Metis_IncreaseStablecoinOptimalBorrowRates_20231113 | 3.914 | 20.662 |
| AaveV3Metis_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismAssets | 0.086 | 24.49 |
| AaveV3OptimismEModes | 0.086 | 24.49 |
| AaveV3Optimism_Disable_Stable_Borrows_20231104 | 3.851 | 20.725 |
| AaveV3Optimism_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.919 | 19.657 |
| AaveV3Optimism_MAIMIMATICDeprecation20231031_20231031 | 4.228 | 20.348 |
| AaveV3Optimism_OnboardNativeUSDCToAaveV3Optimism_20231122 | 5.551 | 19.025 |
| AaveV3Optimism_UpdatePriceOracleSentinel_20231125 | 0.291 | 24.285 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonAssets | 0.086 | 24.49 |
| AaveV3PolygonEModes | 0.086 | 24.49 |
| AaveV3Polygon_ChaosLabsCRVAaveV3PolygonLTReduction_20231106 | 3.416 | 21.16 |
| AaveV3Polygon_Disable_Stable_Borrows_20231104 | 4.139 | 20.437 |
| AaveV3Polygon_GauntletCapRecommendationsForPolygonV3_20231120 | 3.392 | 21.184 |
| AaveV3Polygon_GauntletRecommendationToLowerStMATICMaticXNonEmodeLTPt2_20231117 | 3.571 | 21.005 |
| AaveV3Polygon_IncreaseStablecoinOptimalBorrowRates_20231113 | 4.416 | 20.16 |
| AaveV3Polygon_MAIMIMATICDeprecation20231031_20231031 | 4.226 | 20.35 |
| AaveV3Polygon_WMATICInterestRateUpdate_20231112 | 3.662 | 20.914 |
| Address | 0.086 | 24.49 |
| ChainHelpers | 0.086 | 24.49 |
| ChainIds | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| Create2Utils | 0.164 | 24.412 |
| DataTypes | 0.086 | 24.49 |
| EngineFlags | 0.086 | 24.49 |
| Errors | 4.714 | 19.862 |
| GovHelpers | 0.086 | 24.49 |
| GovV3Helpers | 2.664 | 21.912 |
| GovV3StorageHelpers | 0.086 | 24.49 |
| GovernanceV3Arbitrum | 0.086 | 24.49 |
| GovernanceV3Avalanche | 0.086 | 24.49 |
| GovernanceV3BNB | 0.086 | 24.49 |
| GovernanceV3Base | 0.086 | 24.49 |
| GovernanceV3Ethereum | 0.086 | 24.49 |
| GovernanceV3Gnosis | 0.086 | 24.49 |
| GovernanceV3Metis | 0.086 | 24.49 |
| GovernanceV3Optimism | 0.086 | 24.49 |
| GovernanceV3Polygon | 0.086 | 24.49 |
| HelperStructs | 0.086 | 24.49 |
| IpfsUtils | 0.086 | 24.49 |
| MiscEthereum | 0.086 | 24.49 |
| MiscPolygon | 0.086 | 24.49 |
| MockExecutor | 0.437 | 24.139 |
| PayloadsControllerUtils | 0.086 | 24.49 |
| ProxyHelpers | 0.086 | 24.49 |
| ReserveConfiguration | 0.171 | 24.405 |
| SafeERC20 | 0.086 | 24.49 |
| StdStyle | 0.086 | 24.49 |
| StorageHelpers | 0.086 | 24.49 |
| WadRayMath | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| mock_proposal | 3.653 | 20.923 |
| safeconsole | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 | Test error ❌No files changed, compilation skipped
Running 2 tests for src/20231207_AaveV3Ethereum_GhoIncidentReport_20231126/AaveV3Ethereum_GhoIncidentReport_20231113.t.sol:AaveV3Ethereum_GhoIncidentReport_20231113_Test
[PASS] test_debtTokenRevisionUpdate() (gas: 199738)
[FAIL. Reason: revert: 50] test_defaultProposalExecution() (gas: 216890278)
Logs:
0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0
0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599
0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48
0x6B175474E89094C44Da98b954EedeAC495271d0F
0x514910771AF9Ca656af840dff83E8264EcF986CA
0xBe9895146f7AF43049ca1c1AE358B0541Ea49704
0xdAC17F958D2ee523a2206206994597C13D831ec7
0xae78736Cd615f374D3085123A210448E74Fc6393
0x5f98805A4E8be255a32880FDeC7F6728C6568bA0
0xD533a949740bb3306d119CC777fa900bA034cd52
0x9f8F72aA9304c8B593d555F12eF6589cC3A579A2
0xC011a73ee8576Fb46F5E1c5751cA3B9Fe0af2a6F
0xba100000625a3754423978a60c9317c58a424e3D
0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984
0x5A98FcBEA516Cf06857215779Fd812CA3beF1B32
0xC18360217D8F7Ab5e7c516566761Ea12Ce7F9D72
0x111111111117dC0aa78b770fA6A738034120C302
0x853d955aCEf822Db058eb8505911ED77F175b99e
0xD33526068D116cE69F19A9ee46F0bd304F21A51f
0xAf5191B0De278C7286d6C7CC6ab6BB8A73bA2Cd6
0xdeFA4e8a7bcBA345F687a2f1456F5Edd9CE97202
0x3432B6A60D23Ca0dFCa7761B7ab56459D9C964D0
0xf939E0A03FB07F59A73314E73794Be0E57ac1b4E
E2E: Collateral WETH, TestAsset WETH
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: WETH, Amount: 44221769165283593
WITHDRAW: WETH, Amount: 22110884582641796
WITHDRAW: WETH, Amount: 22110884582641797
BORROW: WETH, Amount 44221769165283593, Stable: false
REPAY: WETH, Amount: 44221769165283593
E2E: Collateral WETH, TestAsset wstETH
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: wstETH, Amount: 38486266652407122
WITHDRAW: wstETH, Amount: 19243133326203561
WITHDRAW: wstETH, Amount: 19243133326203561
BORROW: wstETH, Amount 38486266652407122, Stable: false
REPAY: wstETH, Amount: 38486266652407122
E2E: Collateral WETH, TestAsset WBTC
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: WBTC, Amount: 230656
WITHDRAW: WBTC, Amount: 115328
WITHDRAW: WBTC, Amount: 115327
BORROW: WBTC, Amount 230656, Stable: false
REPAY: WBTC, Amount: 230656
E2E: Collateral WETH, TestAsset USDC
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: USDC, Amount: 100010001
WITHDRAW: USDC, Amount: 50005000
WITHDRAW: USDC, Amount: 50005001
BORROW: USDC, Amount 100010001, Stable: false
REPAY: USDC, Amount: 100010001
E2E: Collateral WETH, TestAsset DAI
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: DAI, Amount: 100042032660022108288
WITHDRAW: DAI, Amount: 50021016330011054144
WITHDRAW: DAI, Amount: 50021016330011054143
BORROW: DAI, Amount 100042032660022108288, Stable: false
REPAY: DAI, Amount: 100042032660022108288
E2E: Collateral WETH, TestAsset LINK
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: LINK, Amount: 6419740342046333320
WITHDRAW: LINK, Amount: 3209870171023166660
WITHDRAW: LINK, Amount: 3209870171023166660
BORROW: LINK, Amount 6419740342046333320, Stable: false
REPAY: LINK, Amount: 6419740342046333320
E2E: Collateral WETH, TestAsset AAVE
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: AAVE, Amount: 1020925147258753703
WITHDRAW: AAVE, Amount: 510462573629376851
WITHDRAW: AAVE, Amount: 510462573629376852
E2E: Collateral WETH, TestAsset cbETH
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: cbETH, Amount: 41892543733690407
WITHDRAW: cbETH, Amount: 20946271866845203
WITHDRAW: cbETH, Amount: 20946271866845203
BORROW: cbETH, Amount 41892543733690407, Stable: false
REPAY: cbETH, Amount: 41892543733690407
E2E: Collateral WETH, TestAsset USDT
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: USDT, Amount: 99990000
WITHDRAW: USDT, Amount: 49995000
WITHDRAW: USDT, Amount: 49995000
BORROW: USDT, Amount 99990000, Stable: false
REPAY: USDT, Amount: 99990000
E2E: Collateral WETH, TestAsset rETH
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: rETH, Amount: 40514450966931854
WITHDRAW: rETH, Amount: 20257225483465927
WITHDRAW: rETH, Amount: 20257225483465927
BORROW: rETH, Amount 40514450966931854, Stable: false
REPAY: rETH, Amount: 40514450966931854
E2E: Collateral WETH, TestAsset LUSD
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: LUSD, Amount: 100369841789326893845
WITHDRAW: LUSD, Amount: 50184920894663446922
WITHDRAW: LUSD, Amount: 50184920894663446923
BORROW: LUSD, Amount 100369841789326893845, Stable: false
REPAY: LUSD, Amount: 100369841789326893845
E2E: Collateral WETH, TestAsset CRV
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: CRV, Amount: 165601923578951677557
WITHDRAW: CRV, Amount: 82800961789475838778
WITHDRAW: CRV, Amount: 82800961789475838778
E2E: Collateral WETH, TestAsset MKR
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: MKR, Amount: 67856472556123930
WITHDRAW: MKR, Amount: 33928236278061965
WITHDRAW: MKR, Amount: 33928236278061965
BORROW: MKR, Amount 67856472556123930, Stable: false
REPAY: MKR, Amount: 67856472556123930
E2E: Collateral WETH, TestAsset SNX
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: SNX, Amount: 27240533914464723508
WITHDRAW: SNX, Amount: 13620266957232361754
WITHDRAW: SNX, Amount: 13620266957232361753
BORROW: SNX, Amount 27240533914464723508, Stable: false
REPAY: SNX, Amount: 27240533914464723508
E2E: Collateral WETH, TestAsset BAL
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: BAL, Amount: 23567674577549433197
WITHDRAW: BAL, Amount: 11783837288774716598
WITHDRAW: BAL, Amount: 11783837288774716598
BORROW: BAL, Amount 23567674577549433197, Stable: false
REPAY: BAL, Amount: 23567674577549433197
E2E: Collateral WETH, TestAsset UNI
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: UNI, Amount: 15996314449150915629
WITHDRAW: UNI, Amount: 7998157224575457814
WITHDRAW: UNI, Amount: 7998157224575457815
BORROW: UNI, Amount 15996314449150915629, Stable: false
REPAY: UNI, Amount: 15996314449150915629
E2E: Collateral WETH, TestAsset LDO
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: LDO, Amount: 40944977488226179597
WITHDRAW: LDO, Amount: 20472488744113089798
WITHDRAW: LDO, Amount: 20472488744113089800
BORROW: LDO, Amount 40944977488226179597, Stable: false
REPAY: LDO, Amount: 40944977488226179597
E2E: Collateral WETH, TestAsset ENS
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: ENS, Amount: 10980757417332531743
WITHDRAW: ENS, Amount: 5490378708666265871
WITHDRAW: ENS, Amount: 5490378708666265873
BORROW: ENS, Amount 10980757417332531743, Stable: false
REPAY: ENS, Amount: 10980757417332531743
E2E: Collateral WETH, TestAsset 1INCH
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: 1INCH, Amount: 266098988823842469398
WITHDRAW: 1INCH, Amount: 133049494411921234699
WITHDRAW: 1INCH, Amount: 133049494411921234698
BORROW: 1INCH, Amount 266098988823842469398, Stable: false
REPAY: 1INCH, Amount: 266098988823842469398
E2E: Collateral WETH, TestAsset FRAX
SUPPLY: WETH, Amount: 4422176916528359398
SUPPLY: FRAX, Amount: 100082497001453327963
WITHDRAW: FRAX, Amount: 50041248500726663981
WITHDRAW: FRAX, Amount: 50041248500726663982
BORROW: FRAX, Amount 100082497001453327963, Stable: false
REPAY: FRAX, Amount: 100082497001453327963
E2E: Collateral WETH, TestAsset GHO
SUPPLY: WETH, Amount: 4422176916528359398
BORROW: GHO, Amount 100000000000000000000, Stable: false
Test result: FAILED. 1 passed; 1 failed; 0 skipped; finished in 32.89s
Ran 1 test suites: 1 tests passed, 1 failed, 0 skipped (2 total tests)
Failing tests:
Encountered 1 failing test in src/20231207_AaveV3Ethereum_GhoIncidentReport_20231126/AaveV3Ethereum_GhoIncidentReport_20231113.t.sol:AaveV3Ethereum_GhoIncidentReport_20231113_Test
[FAIL. Reason: revert: 50] test_defaultProposalExecution() (gas: 216890278)
Encountered a total of 1 failing tests, 1 tests succeeded |
miguelmtzinf
added a commit
that referenced
this pull request
Dec 13, 2023
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) --------- Co-authored-by: Parth Patel <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jan 24, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: added stkgho initialization proposal * feat: fixed proposal description * feat: removed submodule * feat: fixed deployment script * feat: replaced duration calculation * git commit remove submodule * feat: fixed payload build function * update proposal * sync branch * fix: variable name * fix: Fix AIP payload * fix: Fix tests * test: added further test on emission per day * refactor: removed unused constants * fix: catapulta commands * fix: Add fixes to payload * fix: Rebuild proposal with autogenerate tool --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: miguelmtzinf <[email protected]> Co-authored-by: miguelmtz <[email protected]> Co-authored-by: Mark Hinschberger <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jan 24, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add payload * test: Add tests * feat: Add script and tests with final addresses * fix: Fix link and gasLimit amounts * fix: Update dependencies * fix: Fix oracle swap freezer addresses * fix: Bump block number for tests * fix: Reduce LINK amount so its enough in treasury * add test for OracleSwapFreezer * fix: Clean up in tests * docs: Add AIP text * docs: Fix typo in natspec docs Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix typo on natspec docs Co-authored-by: Harsh Pandey <[email protected]> * docs: Fix typo in natspec docs * fix: Add DAO as swap freezer --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: Harsh Pandey <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jun 17, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add AIP code * fix: Fix AIP docs and imports * fix: Remove unnecesary test * fix: Updates risk params * test: Add ccip e2e tests * fix: Fix Arbitrum payload max bytecode size exceeded * feat: Add sophisticated defensive aave seed (#13) * feat: Add sophhisticated defensive aave seed * fix: Allows AaveDefensive contract remove itself as facilitator * fix: Add docs and reduce bytecode size * fix: Reduce Utils lib bytecode size * fix: Fix error in Utils * fix: Add Capped gho usd price oracle * fix: Add AIP draft text * fix: Update block number for tests * fix: Remove unneeded files * fix: Install latest version of gho and ccip repos * fix: Remove unused helper function * fix: Fix AIP text * fix: Remove defensive and use create2 * fix: Add fixed price oracle * fix: Remove unnecessary memory variables * fix: Use create1 and move listing out * fix: Remove listing aip --------- Co-authored-by: Parth Patel <[email protected]>
CheyenneAtapour
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * fix: Fix AIP text --------- Co-authored-by: Parth Patel <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jun 26, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add proposal to onboard GHO * fix: Fix AIP name * fix: Update GHO ir * fix: Fix diff report * fix: Fix typo in AIP text Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix typo in AIP text Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix tests * fix: Fix lint --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: Harsh Pandey <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
Jul 30, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * initial upload: proposal template and fund stream * test: add stream withdraw test * docs: add summary and specs of AIP * test: add fuzz and insufficient funds tests * test: fuzz by seconds instead of days * fix: test changes as per pr comments * fix: comment typo * fix: discussion links, deal funds directly in tests * feat: update proposal doc * fix: doc header and formatting * fix: replace arfc with aip * fix: Fix typo in AIP text Co-authored-by: sendra <[email protected]> * feat: initial upload of template * feat: initial upload doc * fix: aip not arfc * fix: Updates lib * fix: Fix AIP text --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: miguelmtzinf <[email protected]> Co-authored-by: miguelmtz <[email protected]> Co-authored-by: sendra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.