lint: fix some errors found by cppcheck v1.67 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cppcheck 1.67
$ cppcheck --template "{file}:{line}: {severity} ({id}): {message}" \
--quiet --force ./src/
> src/utils.c:257: error (resourceLeak): Resource leak: rf
File pointer 'rf' was overwritten by the following 'fopen' without
having been closed.
I understand that no resources were leaked in this case. In order to
avoid future resource leaks I decided to close it anyway.
Cppcheck 1.67
$ cppcheck --template "{file}:{line}: {severity} ({id}): {message}" \
--quiet --force ./src/
> utils/common.c:599: error (memleak): Memory leak: bssid_copy
'bssid_copy' points to a region of memory that is allocated in this
function but never freed afterwards. 'bssid_copy' is stored on the
stack and "lost" once the function exits.
Cppcheck 1.67
$ cppcheck --template "{file}:{line}: {severity} ({id}): {message}" \
--quiet --force ./src/
> wps/wps_registrar.c:2498: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
> wps/wps_registrar.c:2589: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
> wps/wps_registrar.c:2596: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
> wps/wps_registrar.c:2663: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
> wps/wps_registrar.c:2670: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
> wps/wps_registrar.c:2750: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
> wps/wps_registrar.c:2757: error (invalidFunctionArgBool): Invalid memcmp() argument nr 3. A non-boolean value is required.
The data type of the third argument 'os_memcmp' expects is 'size_t'.
In these cases it was given a boolean expression that always evaluated
to 'true' and was hence interpreted by 'os_memcmp' as an integer '1'.
Therefore, instead of all nonce's bytes only one was actually compared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
cppcheckv1.67 to fix some errors.Issues fixed
Remaining issues found
Going further
You might also want to enable style checks by using
--enable=styleinstead of--enable=warning.Furthermore, I think it would make sense to create a
toolsfolder and add a BASH script likecppcheck.shto it, in order to make finding these kind of defects easier. If this is something you want, I can create a respective pull request.