Update insert_rows() (and _cols()) to two-argument signatures #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating RcppArmadillo to no longer suppress deprecation warning, initially for the value setting use described and changed in detail in RcppCore/RcppArmadillo#391, we found one statement in your package also triggering a number of warnings such as
This PR addresses them. Armadillo no longers off a variant with a boolean, and seemingly always initializes (so some
of your code comments no longer match).
The package passes its tests as before.
It would be much appreciated if you could apply this pull request and update the package at CRAN within the next few months. Let me know if you have any questions.