Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update insert_rows() (and _cols()) to two-argument signatures #39

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

eddelbuettel
Copy link
Contributor

When updating RcppArmadillo to no longer suppress deprecation warning, initially for the value setting use described and changed in detail in RcppCore/RcppArmadillo#391, we found one statement in your package also triggering a number of warnings such as

    fastGrplars.cpp:253:38: warning: ‘void arma::Col<eT>::insert_rows(arma::uword, arma::uword, bool) 
       [with eT = double; arma::uword = unsigned int]’ is deprecated [-Wdeprecated-declarations]

This PR addresses them. Armadillo no longers off a variant with a boolean, and seemingly always initializes (so some
of your code comments no longer match).

The package passes its tests as before.

It would be much appreciated if you could apply this pull request and update the package at CRAN within the next few months. Let me know if you have any questions.

Copy link
Owner

@aalfons aalfons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for providing this fix! I'll submit a new version to CRAN soon.

@aalfons aalfons merged commit 7e39a96 into aalfons:master Jan 18, 2023
@eddelbuettel
Copy link
Contributor Author

eddelbuettel commented Jan 18, 2023

Please also see #402 where @conradsnicta commented after I made the series of pull requests. His recommendation and preference is to ... simply remove the setter because even the non-deprecated one I switched is internal, and the suppression should no longer be needed. Apologies for the double-dance.

@eddelbuettel
Copy link
Contributor Author

Whoops. Please disregard my previous comment. Different issue. For the row/col insertion all is good. Look forward to seeing an updated version at CRAN, and thanks for taking care of it!

@aalfons
Copy link
Owner

aalfons commented Jan 18, 2023

No worries, thanks anyway for reaching out again. I just submitted the new version 0.7.4 to CRAN, it should be available soon.

@eddelbuettel
Copy link
Contributor Author

And there it is -- thanks again, and thank also for listing me as 'ctb' which is very generous for such a small contribution.

@aalfons
Copy link
Owner

aalfons commented Jan 19, 2023

You've also been kind by already providing a patch instead of just asking to fix it, so thanks again for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants