Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email sent file #7

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

vincentjanv
Copy link

@vincentjanv vincentjanv commented Dec 5, 2024

This fixes #4 and #6 by only creating the JSON file after the email was sent. We also add the required URL parameters to download the invoice.

@aSauerwein
Copy link
Owner

hi!

thanks for the pull request.
does it really solve your issues ?

the params are given to base_req as *args and in base_req it`s passed to the request method.
appending all those params to the URL should not make any difference.

i've seen those "read errors" in the past as well, but for me it always looked like a rate limit. Once I implemented the wait between tries it got resolved.

I appreciate the changes to send_mails and dockerfile. I'll for sure accept those.

@vincentjanv
Copy link
Author

hi!

thanks for the pull request. does it really solve your issues ?

the params are given to base_req as *args and in base_req it`s passed to the request method. appending all those params to the URL should not make any difference.

i've seen those "read errors" in the past as well, but for me it always looked like a rate limit. Once I implemented the wait between tries it got resolved.

I appreciate the changes to send_mails and dockerfile. I'll for sure accept those.

Hi! Yeah, not sure why the params didnt work when passing it with as arguments. Manually adding them did work, so I just left it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants