Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create json-file if email was succesfully sent #6

Open
vincentjanv opened this issue Dec 5, 2024 · 0 comments
Open

Only create json-file if email was succesfully sent #6

vincentjanv opened this issue Dec 5, 2024 · 0 comments

Comments

@vincentjanv
Copy link

Right now, it will create an empty file before sending a mail (if it does not already exist for an invoice). But if sending fails, for whatever reason, nothing will be written to the JSON file. After retrying, it will try to parse the (empty) JSON-file but this will fail, resulting in the email never being sent.

I will create a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant