Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize opening proof gpu usage #569

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

sagar-a16z
Copy link
Contributor

@sagar-a16z sagar-a16z commented Jan 24, 2025

  • Supports building --features icicle on MacOS (skips the CUDA backend from icicle-jolt)
  • Ammortizes gpu copy costs for KZG Opening proofs
  • Reduce vector allocations by using std::Borrow
  • Batched hyperKZG witness generation
  • Reintroduced GPU usage for trace commitments where scalars are > 10bit. (needs review, potential memory regression)
  • removed cloning of scalars before appending to transcript in HyperKZG

Brings a 1.4x(30%) speedup to the KZG opening proof. GPU opening proofs are ~2.8x(65%) faster than CPU now.
Net improvement of 15% in prover time GPU vs CPU.

@sagar-a16z sagar-a16z force-pushed the sagar/optimized_opening branch from c903756 to 84407a7 Compare January 24, 2025 20:45
@sagar-a16z sagar-a16z force-pushed the sagar/optimized_opening branch from 61a38bf to 2d349de Compare January 24, 2025 21:07
@sagar-a16z sagar-a16z force-pushed the sagar/optimized_opening branch from d7344b6 to 6373f3f Compare January 26, 2025 21:10
@sagar-a16z sagar-a16z changed the title Sagar/optimized opening Optimize opening proof gpu usage Jan 26, 2025
@sagar-a16z sagar-a16z changed the title Optimize opening proof gpu usage fix: optimize opening proof gpu usage Jan 26, 2025
@sagar-a16z sagar-a16z force-pushed the sagar/optimized_opening branch 3 times, most recently from 8773944 to 1e19b77 Compare January 27, 2025 02:00
@sagar-a16z sagar-a16z force-pushed the sagar/optimized_opening branch from 1e19b77 to cc0b559 Compare January 27, 2025 02:08
@sagar-a16z sagar-a16z marked this pull request as ready for review January 29, 2025 00:40
@sagar-a16z sagar-a16z requested a review from moodlezoup January 29, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant