-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimize opening proof gpu usage #569
Open
sagar-a16z
wants to merge
15
commits into
main
Choose a base branch
from
sagar/optimized_opening
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+470
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-a16z
force-pushed
the
sagar/optimized_opening
branch
from
January 24, 2025 20:45
c903756
to
84407a7
Compare
sagar-a16z
force-pushed
the
sagar/optimized_opening
branch
from
January 24, 2025 21:07
61a38bf
to
2d349de
Compare
sagar-a16z
force-pushed
the
sagar/optimized_opening
branch
from
January 26, 2025 21:10
d7344b6
to
6373f3f
Compare
sagar-a16z
changed the title
Optimize opening proof gpu usage
fix: optimize opening proof gpu usage
Jan 26, 2025
sagar-a16z
force-pushed
the
sagar/optimized_opening
branch
3 times, most recently
from
January 27, 2025 02:00
8773944
to
1e19b77
Compare
sagar-a16z
force-pushed
the
sagar/optimized_opening
branch
from
January 27, 2025 02:08
1e19b77
to
cc0b559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--features icicle
on MacOS (skips the CUDA backend from icicle-jolt)std::Borrow
Brings a 1.4x(30%) speedup to the KZG opening proof. GPU opening proofs are ~2.8x(65%) faster than CPU now.
Net improvement of 15% in prover time GPU vs CPU.