Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embrace uv #422

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Embrace uv #422

merged 8 commits into from
Dec 4, 2024

Conversation

karmacoma-eth
Copy link
Collaborator

  • recommend the uv workflow in README.md and CONTRIBUTING.md
  • replace requirements-dev.txt with an optional dependency group in pyproject.toml
  • replace remaining mentions of black with ruff
  • switch relevant workflows and dockerfiles to uv

Copy link
Collaborator

@daejunpark daejunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

two things:

  • could you check the ffi test failure in the ci?
  • could you confirm it's intentional to include uv.lock file in the repo?

uv.lock Outdated Show resolved Hide resolved
@karmacoma-eth
Copy link
Collaborator Author

looks great, thanks!

two things:

* could you check the ffi test failure in the ci?

* could you confirm it's intentional to include uv.lock file in the repo?

failures are fixed, and we decided to not include the uv.lock file in the repo after all (so we have lower friction and commit noise at the cost fully reproducible builds)

@karmacoma-eth karmacoma-eth merged commit 2b68913 into main Dec 4, 2024
45 checks passed
@karmacoma-eth karmacoma-eth deleted the embrace-uv branch December 4, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants