Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more docker workflow tweaks #405

Merged
merged 1 commit into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/publish-halmos-builder-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ name: Push halmos-builder package
on:
# only trigger manually, this is independent from halmos releases
workflow_dispatch:
workflow_run:
workflows: ["Push solvers package"]
types:
- completed
Comment on lines +7 to +10
Copy link
Collaborator Author

@karmacoma-eth karmacoma-eth Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, this was triggered by a successful run of publish-solvers-package.yml: https://github.com/a16z/halmos/actions/runs/11751217641

push:
paths:
- packages/halmos-builder/**/*
Expand All @@ -15,6 +19,8 @@ env:
jobs:
# This pushes the image to GitHub Packages.
push:
# if triggered by a workflow_run, only run if the previous workflow succeeded
if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name != 'workflow_run' }}
runs-on: ubuntu-latest
permissions:
packages: write
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/publish-halmos-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: Push halmos package

on:
workflow_dispatch:
workflow_run:
workflows: ["Push halmos-builder package"]
types:
- completed
Comment on lines +6 to +9
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

push:
paths:
- packages/halmos/**/*
Expand All @@ -11,13 +15,14 @@ on:
# push when we release a new tagged version
- 'v*'


env:
IMAGE_NAME: halmos

jobs:
# This pushes the image to GitHub Packages.
push:
# if triggered by a workflow_run, only run if the previous workflow succeeded
if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name != 'workflow_run' }}
runs-on: ubuntu-latest
permissions:
packages: write
Expand All @@ -40,7 +45,7 @@ jobs:
run: docker build . --file packages/halmos/Dockerfile --tag $IMAGE_NAME --label "runnumber=${GITHUB_RUN_ID}"

- name: Print halmos version
run: docker run $IMAGE_NAME --version
run: docker run $IMAGE_NAME halmos --version
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this fix to publish halmos:latest


- name: Push image
run: |
Expand Down
Loading