fix all_items error when bool(key) is False

Signed-off-by: Zhiyuan Chen <[email protected]>
ZhiyuanChen · Sep 20, 2023 · 74cabb3 · 74cabb3
1 parent ce4b229
commit 74cabb3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/chanfig/flat_dict.py b/chanfig/flat_dict.py
@@ -250,6 +250,8 @@ def set(self, name: Any, value: Any) -> None:
             'liu'
         """
 
+        if name is Null:
+            raise ValueError("name must not be null")
         if name in self and isinstance(self.get(name), Variable):
             self.get(name).set(value)
         else:

diff --git a/chanfig/nested_dict.py b/chanfig/nested_dict.py
@@ -183,9 +183,9 @@ def all_keys(self) -> Generator:
         delimiter = self.getattr("delimiter", ".")
 
         @wraps(self.all_keys)
-        def all_keys(self, prefix=""):
+        def all_keys(self, prefix=Null):
             for key, value in self.items():
-                if prefix:
+                if prefix is not Null:
                     key = str(prefix) + str(delimiter) + str(key)
                 if isinstance(value, NestedDict):
                     yield from all_keys(value, key)
@@ -229,9 +229,9 @@ def all_items(self) -> Generator:
         delimiter = self.getattr("delimiter", ".")
 
         @wraps(self.all_items)
-        def all_items(self, prefix=""):
+        def all_items(self, prefix=Null):
             for key, value in self.items():
-                if prefix:
+                if prefix is not Null:
                     key = str(prefix) + str(delimiter) + str(key)
                 if isinstance(value, NestedDict):
                     yield from all_items(value, key)