fix value in config file overrided by default

Signed-off-by: Zhiyuan Chen <[email protected]>

chanfig/flat_dict.py

@@ -400,7 +400,7 @@ def hasattr(self, name: str) -> bool:
         except AttributeError:
             return False
 
-    def __missing__(self, name: str, default: Any = Null) -> Any:
+    def __missing__(self, name: str, default: Any = Null) -> Any:  # pylint: disable=R1710
         if name == "_ipython_canary_method_should_not_exist_":
             return
         if default is Null:
@@ -867,7 +867,9 @@ def from_jsons(cls, string: str, *args, **kwargs) -> FlatDict:
         ```
         """
 
-        return cls(**json_loads(string, *args, **kwargs))
+        config = cls()
+        config.update(json_loads(string, *args, **kwargs))
+        return config
 
     def yaml(self, file: File, *args, **kwargs) -> None:
         r"""
@@ -950,7 +952,10 @@ def from_yamls(cls, string: str, *args, **kwargs) -> FlatDict:
 
         if "Loader" not in kwargs:
             kwargs["Loader"] = YamlLoader
-        return cls(**yaml_load(string, *args, **kwargs))
+
+        config = cls()
+        config.update(yaml_load(string, *args, **kwargs))
+        return config
 
     @staticmethod
     @contextmanager

chanfig/utils.py

@@ -62,7 +62,7 @@ def __contains__(self, name):
     def __iter__(self):
         return self
 
-    def __next__(self):
+    def __next__(self):  # pylint: disable=R0201
         raise StopIteration
 
 

tests/test_config.py

@@ -5,7 +5,7 @@ class TestConfig(Config):
     __test__ = False
 
     def __init__(self, *args, **kwargs):
-        super().__init__()
+        super().__init__(*args, **kwargs)
         num_classes = Variable(10)
         self.name = "CHANfiG"
         self.seed = Variable(1013)
@@ -31,3 +31,13 @@ def test_variable(self):
 
     def test_fstring(self):
         assert f"seed{self.config.seed}" == "seed1013"
+
+    def test_load(self):
+        self.config.name = "Test"
+        self.config.dataset.num_classes = 12
+        self.config.dump("tests/test_config.json")
+        self.config = self.config.load("tests/test_config.json")
+        assert self.config.name == "Test"
+        assert self.config.network.name == "ResNet18"
+        assert self.config.network.num_classes == 12
+        assert self.config.dataset.num_classes == 12