fix conflicts when key name is items, keys, values, etc.

Signed-off-by: Zhiyuan Chen <[email protected]>

chanfig/flat_dict.py

@@ -197,7 +197,11 @@ def __post_init__(self, *args, **kwargs) -> None:
         pass
 
     def __getattribute__(self, name: Any) -> Any:
-        if (name not in ("getattr",) and not (name.startswith("__") and name.endswith("__"))) and name in self:
+        if (
+            (name not in ("getattr",) and not (name.startswith("__") and name.endswith("__")))
+            and name not in dir(self.__class__)
+            and name in self
+        ):
             return self.get(name)
         return super().__getattribute__(name)
 

tests/test_flat_dict.py

@@ -110,3 +110,13 @@ def test_construct_namespace(self):
         d = FlatDict(parser.parse_args(["--name", "chang", "--seed", "1013"]))
         assert d.name == "chang"
         assert d.seed == 1013
+
+    def test_conflicts(self):
+        d = FlatDict(keys=0, values=1, items=2)
+        p = {"keys": 0, "values": 1, "items": 2}
+        assert d["keys"] == 0
+        assert d["values"] == 1
+        assert d["items"] == 2
+        assert d.keys() == p.keys()
+        assert list(d.values()) == list(p.values())  # dict_values can't be compared directly
+        assert d.items() == p.items()