Fix padding being too small above menu title

ZeusWPI · Apr 22, 2019 · 492d1cc · 492d1cc
1 parent aa8027b
commit 492d1cc
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/app/src/main/java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java b/app/src/main/java/be/ugent/zeus/hydra/common/ui/widgets/MenuTable.java
@@ -116,8 +116,7 @@ private void createText(String text, boolean isTitle, boolean isHtml) {
             } else {
                 v.setTextAppearance(R.style.Subhead);
             }
-            textPaddingTop = rowPadding;
-
+            textPaddingTop = getContext().getResources().getDimensionPixelSize(R.dimen.vertical_padding);
         } else if (messagePaddingTop) {
             textPaddingTop = getContext().getResources().getDimensionPixelSize(R.dimen.vertical_padding);
         } else {

diff --git a/app/src/main/java/be/ugent/zeus/hydra/minerva/common/MinervaRequest.java b/app/src/main/java/be/ugent/zeus/hydra/minerva/common/MinervaRequest.java
@@ -72,7 +72,6 @@ public Result<T> execute(@NonNull Bundle args) {
                     throw e; // Proceed with error.
                 }
 
-                // TODO: log if this happens at all.
                 // This should never be the case:
                 // 1. If the access token is expired, the getToken() function will have caught and resolved it.
                 // 2. If not resolvable, an AuthenticatorActionException will be thrown.