Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matush/Semester picker in administration #323

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

Matushl
Copy link
Member

@Matushl Matushl commented Dec 11, 2023

build on #316, close #303 , ale mozno by sme chceli zalozit nove issue na vytvorenie novej page, ktora by osahovala nejake rascestnik do buducnosti

Trochu som sa s tym hral, avsak nie som si isty ze ci to posunut do topgridu je dobry napad. @vikibrezinova pozri sa na to prosim a povedz ci to takto moze byt

Prerobil som url pre seminar administraciu aby zobrazovala /{rocnik}/{semester} takze semester picker vie detekovat z URL co je zvoleny semseter.

Nasledne bolo este potrebne:

  • opravit button Spat na semester v administracii ulohy
  • bolo by vhodne do Title (alebo niekde) v administracii ulohy zaznacit na akom semestri nachadzeme

@Matushl Matushl changed the title Matush/Semester picker v administracii WIP: Matush/Semester picker v administracii Dec 11, 2023
@Matushl Matushl force-pushed the matush/semester-picker branch from e7d8eaf to 1c79191 Compare December 11, 2023 14:02
@Matushl Matushl changed the title WIP: Matush/Semester picker v administracii WIP: Matush/Semester picker in administration Dec 11, 2023
@Matushl Matushl force-pushed the matush/semester-picker branch from 1c79191 to e418b01 Compare December 11, 2023 16:48
@Matushl Matushl marked this pull request as ready for review December 11, 2023 16:52
@Matushl Matushl requested a review from rtrembecky December 11, 2023 16:52
@Matushl Matushl changed the title WIP: Matush/Semester picker in administration Matush/Semester picker in administration Dec 11, 2023
Copy link
Contributor

@vikibrezinova vikibrezinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preklikala som si to, je to funkcne a vyzera to v pohode. Kod som nepozerala nejako podrobne, aj tak sa necitim kvalifikovana sa k nemu vyjadrit.

Ja som to povodne nedavala do topgridu, ale tam nizsie pre to, ze mi prislo, ze tam v topgride by som si to nevsimla, keby prvykrat to mam pustene. Na druhu stranu takto sa to pouziva vo vysledkoch aj zadaniach, takze to je aspon jednotne a vlastne to dava vacsi zmysel. Takze si myslim, ze to moze byt takto.

Na razcestnik sa kludne moze zalozit nova issue, ale myslim ze to nie je take podstatne, takze podla mna kludne do 2.0. Takto ako to teraz je mi to pride dostatocne funkcne.

@Matushl Matushl merged commit 13c9979 into master Dec 12, 2023
1 check passed
@Matushl Matushl deleted the matush/semester-picker branch December 12, 2023 22:07
@Matushl
Copy link
Member Author

Matushl commented Dec 13, 2023

Na razcestnik sa kludne moze zalozit nova issue, ale myslim ze to nie je take podstatne, takze podla mna kludne do 2.0. Takto ako to teraz je mi to pride dostatocne funkcne.

uz som ho zalozil a nahodil do 2.0 #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opravovanie - semester picker
2 participants