Reset password - reset password dialog #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeffer
force-pushed
the
192-reset-password
branch
from
2e49571 to
a0b9bc9
Compare
vgeffer
force-pushed
the
192-reset-password
branch
from
a0b9bc9 to
93af449
Compare
rtrembecky
reviewed
Dec 9, 2023
| @@ -38,7 +38,7 @@ export const Authentication: FC = () => { | |||
| <Overlay display={displayAuthenticationOverlay} closeOverlay={toggleDisplayLoginOverlay}> | |||
| <div className={styles.authenticationContainer}> | |||
| <div className={styles.content}> | |||
| <LoginForm closeOverlay={toggleDisplayLoginOverlay} /> | |||
| <LoginFormWrapper closeOverlay={toggleDisplayLoginOverlay} /> | |||
There was a problem hiding this comment.
nie som si isty, ci mozeme ratat s tym, ze toggleDisplayLoginOverlay unmountne LoginFormWrapper component. ked sa neunmountne a ostane len nejak invisible, tak pri znovuotvoreni loginu by som cakal zachovany stav, ze resetujeme heslo
| import {LoginForm} from '../LoginForm/LoginForm' | ||
| import {PasswordResetRequestForm} from '../PasswordReset/PasswordResetRequest' | ||
|
|
||
| export interface ILoginFormWrapper { |
There was a problem hiding this comment.
skor pouzivame type miesto interface, co je ale uplny nitpick.
skor ale zapindam ze pouzivajme naming "ComponentProps", tzn. ja bys om pisal export type LoginFormWrapperProps = {
rtrembecky
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1/2)