Close and back button in profile changes #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matushl
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Jedna drobnost pri dialogu, plus druha vec: vsetky dialogy/potvrdzovania sme doteraz na stranke robili tak ze pozitivna odpoved bola v pravo a negativna vlavo. Bude to mozno potrebne este niekedy prejst, ale bo otvorit tu diskusiu, ale pre zatial prosim vymen poradie aj pre zmenu hesla aj pre ukladanie profilu nech to mame zatial jednotne.
| <Button type="submit" onClick={handleSubmit(onSubmit)}> | ||
| Potvrdiť | ||
| </Button> | ||
| <Button onClick={close}>Zavrieť</Button> |
There was a problem hiding this comment.
bolo by este vhodne pustit reset() aby sa vymazali udaje z formulara.
Ak si to chces vyskusat, tak vypln nejake udaje, daj zavriet a otvor si zmenu hesla znova, idealne by mala byt prazdna, no momentalne nie je.
Matushl
requested changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #200