-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File uploader - uprava upozorneni #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, improvement. nic neblokuje merge, ale bolo by fajn doladit
src/components/Problems/Problems.tsx
Outdated
@@ -54,6 +54,7 @@ export const Problems: FC = () => { | |||
const semesterId = series?.semester ?? -1 | |||
const canSubmit = series?.can_submit ?? false | |||
const canResubmit = series?.can_resubmit ?? canSubmit | |||
const isAfterDeadline = new Date(series?.deadline ?? '') < new Date() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to si skusal? ci na dateoch je nakodeny operator aby to porovnalo timestampy alebo nieco? 😄 hladal by som nejake isBefore/isAfter funkcie v luxone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no a podobne ako v banneri, budeme asi chciet, aby tu nieco tikalo, checkoval by som tie datumy kludne kazdu sekundu. nejaky useInterval
by som cakal zase v use-hooks-ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
luxon dokonca odporuca pouzivat obycajne operatory >
<=
moment/luxon#108
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, nice... ale 😀 oni porovnavaju svoje DateTimes, nie JS Dates 😀 tomu by som teda veril viac 😀 takze bude vhodne DateTime.fromISO() a nejake DateTime.now() abo co a tie porovnat (now som si vymyslel, neviem ako sa robi current v luxone, ale predpokladam)
a4cae75
to
7d6be1a
Compare
7d6be1a
to
426d417
Compare
solve #130