Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File uploader - uprava upozorneni #221

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

Matushl
Copy link
Member

@Matushl Matushl commented Nov 12, 2023

solve #130

@Matushl Matushl requested a review from rtrembecky November 12, 2023 12:12
@Matushl Matushl linked an issue Nov 12, 2023 that may be closed by this pull request
Copy link
Collaborator

@rtrembecky rtrembecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, improvement. nic neblokuje merge, ale bolo by fajn doladit

@@ -54,6 +54,7 @@ export const Problems: FC = () => {
const semesterId = series?.semester ?? -1
const canSubmit = series?.can_submit ?? false
const canResubmit = series?.can_resubmit ?? canSubmit
const isAfterDeadline = new Date(series?.deadline ?? '') < new Date()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to si skusal? ci na dateoch je nakodeny operator aby to porovnalo timestampy alebo nieco? 😄 hladal by som nejake isBefore/isAfter funkcie v luxone

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no a podobne ako v banneri, budeme asi chciet, aby tu nieco tikalo, checkoval by som tie datumy kludne kazdu sekundu. nejaky useInterval by som cakal zase v use-hooks-ts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luxon dokonca odporuca pouzivat obycajne operatory > <= moment/luxon#108

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, nice... ale 😀 oni porovnavaju svoje DateTimes, nie JS Dates 😀 tomu by som teda veril viac 😀 takze bude vhodne DateTime.fromISO() a nejake DateTime.now() abo co a tie porovnat (now som si vymyslel, neviem ako sa robi current v luxone, ale predpokladam)

src/components/Problems/Problems.tsx Outdated Show resolved Hide resolved
@Matushl Matushl force-pushed the 130-file-uploader-nahravanie-po-druhy-krat branch from a4cae75 to 7d6be1a Compare November 15, 2023 23:52
@Matushl Matushl force-pushed the 130-file-uploader-nahravanie-po-druhy-krat branch from 7d6be1a to 426d417 Compare November 15, 2023 23:53
@Matushl Matushl merged commit d7f5ec8 into master Nov 15, 2023
1 check passed
@Matushl Matushl deleted the 130-file-uploader-nahravanie-po-druhy-krat branch November 15, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File uploader - nahravanie po druhy krat
2 participants