Logo model #243
Merged
Logo model #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes: #229 |
kovacspe
reviewed
Nov 11, 2023
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Toto by nemalo byt potrebne pridavat
cms/views.py
Outdated
| raise exceptions.PermissionDenied( | ||
| 'Nedostatočné práva na vytvorenie tohoto objektu') | ||
|
|
||
| @action(methods=['get'], detail=True, url_path='download') |
There was a problem hiding this comment.
Túto metódu netreba. Stačí ak v response príde link na súbor. Tento súbor sa totiž bude servovať staticky
cms/views.py
Outdated
| return response | ||
|
|
||
| @action(methods=['post'], detail=False, url_path='upload') | ||
| def upload_publication(self, request): |
There was a problem hiding this comment.
Toto by sa nemalo volať upload_publication
cms/views.py
Outdated
| file = request.data['file'] | ||
| if mime_type(file) not in ['application/jpg', 'application/png']: | ||
| raise exceptions.ParseError(detail='Nesprávny formát') | ||
|
|
There was a problem hiding this comment.
Tento endpoint iba skontroluje ci tam je file. Ale nevytvori objekt.
kovacspe
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.