Contribution expired notification #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No new packages were introduced in this PR, so the snyk errors should be ignored (for the sake of this PR, to be addressed separately.) |
AMStrix
reviewed
Mar 8, 2019
|
|
||
| @staticmethod | ||
| def process_task(task): | ||
| from grant.proposal.models import ProposalContribution |
There was a problem hiding this comment.
Yep, unfortunately all of the job classes seem to need to handle it this way.
AMStrix
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Lovely! Works great.
I've no strong opinion on whether to add a contribution.status. It would be fairly painless to add if needed at some point.
I did notice, in the course of testing, that attempting to make two contributions in a row sends the user directly to "Success" modal content w/o payment info. I'll make an issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #198.
What This Does
Creates a new task that gets made on contribution creation. 24h after the contribution is made, if it's still pending, emails the user to indicate the contribution has expired. Doesn't change anything in the database, simply sends the notification. This of course does not work on anonymous contributions.
Maybe we should add a new
contribution.statusfor expired contributions instead of it being kind of implicit, let me know what y'all think.Steps to Test
tasktablehttp://localhost:5000/api/v1/task, confirm you get an expiry emailtaskrow is createdScreenshots