Fix failure to read entire reply from S3v3

ZJONSSON · May 30, 2021 · a61bb36 · a61bb36
1 parent e56ae99
commit a61bb36
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/lib/reader.js b/lib/reader.js
@@ -382,17 +382,19 @@ class ParquetEnvelopeReader {
         let getObjectCommand = await client.send(
           new GetObjectCommand({Range: range, ...params})
         );
-        let body = await new Promise((resolve) => {
+        let body = await new Promise (resolve => {
           let bodyBuffer, data;
-          getObjectCommand.Body.on('readable', function () {
-            do {
-              if (data) {
+          getObjectCommand.Body.on('end', function() {
+            resolve(bodyBuffer);
+          });
+          getObjectCommand.Body.on('readable', function() {
+            while (data = this.read()) {
+              if (bodyBuffer) {
                 bodyBuffer = Buffer.concat([bodyBuffer, data]);
               } else {
-                bodyBuffer = this.read() || bodyBuffer;
+                bodyBuffer = data;
               }
-            } while (data = this.read()); //eslint-disable-line no-cond-assign
-            resolve(bodyBuffer);
+            }
           });
         });
         return body;