Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mypy support #156

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add Mypy support #156

wants to merge 2 commits into from

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Jan 23, 2022

@ZENALC feel free to contribute - slowly going through the list, perhaps you'll have more insights :P

@ZENALC
Copy link
Owner

ZENALC commented Jan 24, 2022

looks great :D

what do you think of upping the py v to 3.9+ and using built-in types?

so, we can do list[str] instead of importing List from typing :D

@inverse
Copy link
Contributor Author

inverse commented Jan 24, 2022

Could do but it might make it less accessible for people and current users of the product.

@ZENALC
Copy link
Owner

ZENALC commented Jan 27, 2022

Yep, you're right. Let's just use normal type hints for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants