Fuzzer mods #328
Merged
Fuzzer mods #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacav
force-pushed
the
dacav/fuzzer_mods
branch
from
bcdaac7 to
fd333c5
Compare
LDVG
reviewed
Dec 17, 2024
Under Linux the read call seems to accept NULL as a parameter:
$ cat try.c
#include <unistd.h>
#include <err.h>
int main(void)
{
int i = read(0, NULL, 4);
err(1, "read");
return 0;
}
$ make try
cc try.c -o try
$ ./try </dev/random
try: read: Bad address
Such behaviour is not specified by POSIX, so we should
catch it.
Since we are at it, catching read(-1, ...) is probably a good
idea, since code that does that is arguably wrong.
dacav
force-pushed
the
dacav/fuzzer_mods
branch
from
fd333c5 to
9d1ef68
Compare
|
I'd prefer a |
dacav
force-pushed
the
dacav/fuzzer_mods
branch
from
9d1ef68 to
a6e50d0
Compare
|
Yay! Thanks! |
LDVG
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes I think would improve fuzzing :)