Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update
full_join
methodRelated Issue
full_join()
on a treedata object does not work with the standard dplyr UI ofby=c('columnX'='columnY')
related issue is YuLab-SMU/tidytree#32.
In addition, the original
full_join
will generate errors, if the externaldata.frame
contains labels that are not present in the tree.or the
da
contains duplicatednode
rows, the originalphylo
tree structure will be damaged.the
t8
is fromda
, but it doesn't exist inphylo
tree. I think it is better to be removed when theda
was joined, so thefull_join
might be like theleft_join
ontreedata
orphylo
class. Because it is difficult to add a newnode
ortip
in aphylo
tree without other useful information such asedge.length
etc.So this update
by
argument supportby=c('columnX'='columnY')
.node
orlabel
that doesn't exist inphylo
will be removed after joining, so it is likeleft_join
.Example