Fix setting bits of parameters in setundef pass #4733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
This PR fixes setting bits of parameters in
setundef
pass.Explain how this is achieved.
Currently we are looping through module parameters using
for (auto bit : parameter.second)
.It is equivalent to:
where
auto
is resolved toRTLIL::Const
.Iterator that we are using is defined in
Const
class which iterates throughState
enum.operator *
of iterator returns copy of the state.This PR changes to use reference instead.
If applicable, please suggest to reviewers how they can test the change.
I attached example test case that showcase the problem.
Fixes: #4732