Respect $SOURCE_DATE_EPOCH in generate_bram_types_sim.py #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Downstream pull request: https://src.fedoraproject.org/rpms/yosys/pull-request/5 |
whitequark
reviewed
Oct 24, 2024
| with open(filename, "w") as f: | ||
| f.write("// **AUTOGENERATED FILE** **DO NOT EDIT**\n") | ||
| f.write(f"// Generated by {sys.argv[0]} at {datetime.now(timezone.utc)}\n") | ||
| f.write(f"// Generated by {sys.argv[0]} at {build_date}\n") |
There was a problem hiding this comment.
Do we even need the build date here? The file modification time indicates it already...
There was a problem hiding this comment.
I don't think it's particularly useful, but meh, I don't care either way, as long as the file doesn't change between rebuilds ;)
There was a problem hiding this comment.
I think you can go ahead and remove the generation time outright. It's an outlier among the other "Generated by" string formatting in the codebase
I'm working on build reproducibility of Fedora packages, and this patch fixes an issue observed in test rebuilds: the timestamp was set to the actual time of the build, making builds nonreproducible. Other "Generated by" strings do not include a timestamp, so drop it here too.
keszybz
force-pushed
the
use-SOURCE_DATE_EPOCH
branch
from
ca688a8
to
26a3478
Compare
widlarizer
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
I'm working on build reproducibility of Fedora packages, and this patch fixes an issue observed in test rebuilds.
Explain how this is achieved.
The variable is set in build environments to allow the build to be reproducible (identical result in independent builds), see https://reproducible-builds.org/docs/source-date-epoch/. The code snippet is based on the sample from that page too.
If applicable, please suggest to reviewers how they can test the change.
Generate the output without $SOURCE_DATE_EPOCH set, which should result in a file with a current timestamp, and then again with SOURCE_DATE_EPOCH set, which should result in the specified timestamp.