Add support for unpacked structs #4180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be rebased against master after merge of #4100. |
daglem
force-pushed
the
unpacked-structs
branch
from
e3bf967
to
acecd81
Compare
daglem
force-pushed
the
unpacked-structs
branch
from
acecd81
to
eb4b6c6
Compare
|
To be rebased against master after merge of #3877. |
daglem
force-pushed
the
unpacked-structs
branch
from
eb4b6c6
to
24e64b0
Compare
nordshift on a net or variable yields generation of muxes instead of shift circuits for dynamic rvalue indexing, akin to nowrshmsk for lvalue indexing. To facilitate this, the AST transformations for rvalue indexing are moved from genrtlil.cc to simplify.cc, bringing them in line with transformations for lvalue indexing.
… AST_SHIFTX AST_CAST_SIZE on the right operand caused an unsigned operand to be signed. This is corrected by handling the right operand like in AST_POW.
This also corrects the calculation of bit widths, using the new function min_bit_width.
Unpacked structs/unions may now be declared, and can contain members with unpacked dimensions. This is just syntactic sugar; unpacked structs/unions are handled as if they were packed. Note that arrays of structs/unions are still not supported.
daglem
force-pushed
the
unpacked-structs
branch
from
24e64b0
to
f9381ba
Compare
|
Can anyone with access to Verific identify which line(s) in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for unpacked structs