Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #22

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Various improvements #22

merged 3 commits into from
Aug 26, 2020

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Aug 17, 2020

Added rest of improvements and fixes issue #19.

Copy link
Member

@nakengelhardt nakengelhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wraparound is working well.
I wonder if you can remove the path from the name and source location properties too? It has line information so probably basename doesn't know how to handle it...

@mmicko
Copy link
Member Author

mmicko commented Aug 17, 2020

Thing is that with current code source location is unique, and we do search (and need to search) by full name always, otherwise it can be problem in case we have two files named same on two different locations. Will check if I can just display short version (but still use full for access/search)

@nakengelhardt
Copy link
Member

Thanks! Should we also change it in this view?
Screenshot 2020-08-03 at 15 51 13
I'm a little bit of two minds, on the one hand currently the fields are not very readable but on the other hand they represent database entries...

@mmicko
Copy link
Member Author

mmicko commented Aug 19, 2020

I would say, it is better to leave it to represent real data, also if you stay bit longer over item you will get full text in tooltip

@mmicko mmicko merged commit 1030e7d into master Aug 26, 2020
@mmicko mmicko deleted the improve branch November 16, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants