Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions/test: anticipate PHP 8.4 release #388

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Nov 10, 2024

GH Actions/test: anticipate PHP 8.4 release

  • Builds against PHP 8.4 are no longer allowed to fail.
  • Update PHP version on which code coverage is run (high should now be 8.4).
  • Add allowed to fail build against PHP 8.5.

GH Actions: use "nightly" alias and lint against nightly

Setup-PHP offers the 'nightly' alias for the "next" PHP version (PHP source "master" branch).

Using that alias will reduce the manual changes needed to the workflow each year.

We'll still need to expand the list of PHP versions to test against once a year, but we won't need to update the version number for the next PHP version anymore.

Additionally, this commit enables running the PHP linting against the next PHP version. This wasn't previously enabled, though it should have been.

* Builds against PHP 8.4 are no longer allowed to fail.
* Update PHP version on which code coverage is run (high should now be 8.4).
* Add _allowed to fail_ build against PHP 8.5.
Setup-PHP offers the `'nightly'` alias for the "next" PHP version (PHP source "master" branch).

Using that alias will reduce the manual changes needed to the workflow each year.

We'll still need to expand the list of PHP versions to test against once a year, but we won't need to update the version number for the _next_ PHP version anymore.

Additionally, this commit enables running the PHP linting against the _next_ PHP version. This wasn't previously enabled, though it should have been.
@coveralls
Copy link

Coverage Status

coverage: 99.248%. remained the same
when pulling fff0385 on feature/ghactions-dont-fail-on-8.4
into a65412f on develop.

@jrfnl jrfnl merged commit 8289d81 into develop Nov 10, 2024
32 checks passed
@jrfnl jrfnl deleted the feature/ghactions-dont-fail-on-8.4 branch November 10, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants