Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab focus for ai optimize toast element #21635

Draft
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Draft

Fix tab focus for ai optimize toast element #21635

wants to merge 15 commits into from
+153 −23

Conversation

Jordi-PV
Copy link
Contributor

@Jordi-PV Jordi-PV commented Sep 13, 2024 •
edited
Loading

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the AI Optimize toast notification would not be accessible for keyboard and screenreader users.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

mykola and others added 8 commits July 5, 2024 15:00
@Jordi-PV Jordi-PV requested a review from a team as a code owner September 13, 2024 09:30
@Jordi-PV Jordi-PV marked this pull request as draft September 13, 2024 09:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

@Jordi-PV Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@Jordi-PV Jordi-PV added changelog: other Needs to be included in the 'Other' category in the changelog changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog and removed changelog: other Needs to be included in the 'Other' category in the changelog labels Sep 13, 2024
@coveralls
Copy link

coveralls commented Sep 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 26bee99b9f7b80ebab79aed0993ba90c6eb24a4b

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix-tab-focus-for-ai-optimize-toast-element at 26.839%
Totals Coverage Status
Change from base Build 1584e5a2b41465c3e61e992fd324fb4563c702b5: 26.8%
Covered Lines: 3725
Relevant Lines: 12761
💛 - Coveralls

igorschoester
igorschoester reviewed Nov 25, 2024
View reviewed changes
packages/ui-library/src/elements/toast/index.js

Toast.propTypes = {
children: PropTypes.node,
id: PropTypes.string.isRequired,
role: PropTypes.string.isRequired,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be a required prop breaking API change?

You can already add it via the prop spread now. So you're saying noone may use a Tooltip without specifying a role.
IMO this seems a bit overzealous for the purpose of an element in our UI library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorschoester igorschoester igorschoester left review comments

Assignees
No one assigned
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jordi-PV @coveralls @igorschoester @mykola