Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GET, PUT and DELETE user by id #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add GET, PUT and DELETE user by id #6

wants to merge 5 commits into from

Conversation

eviema
Copy link

@eviema eviema commented Oct 18, 2017

Hi Charlie, please check my homework. Looking forward to your feedback!

YixiuJiang
YixiuJiang reviewed Oct 18, 2017
View reviewed changes
Copy link
Owner

@YixiuJiang YixiuJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put out/* into gitignore and update your pull request

YixiuJiang
YixiuJiang requested changes Oct 18, 2017
View reviewed changes
Copy link
Owner

@YixiuJiang YixiuJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete files from out/ and update your pull request and put out folder into gitignore

@eviema eviema closed this Oct 19, 2017
@eviema eviema reopened this Oct 20, 2017
@eviema
Copy link
Author

eviema commented Oct 20, 2017 •
edited
Loading

Hi Charlie,

I've deleted the contents in out/ and added the directory in .gitignore.

Besides, I have:

  • changed return type String to void for methods updateUserById and deleteUserById, to conform to API design guidelines, and
  • added getter and setter for user id in user model.

Thanks,
Evie

YixiuJiang
YixiuJiang reviewed Oct 20, 2017
View reviewed changes
Copy link
Owner

@YixiuJiang YixiuJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

src/main/java/spaceshuttle/controller/UserController.java Outdated
// Homework 2: PUT user by id
@PutMapping(value = "/{id}")
public @ResponseBody
String updateUserById(@PathVariable Long id,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use requestbody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YixiuJiang YixiuJiang YixiuJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eviema @YixiuJiang