Convert database entities from TypeORM Repositories to extending BaseEntity #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtends BaseEntity
…tion extends BaseEntity
… extends BaseEntity
… GroupMember extends BaseEntity
6 tasks
|
LGTM! Awesome, thanks! I will keep #205 blocked for now still since the plan is to achieve a common solution for Deadchat and DailyChallenge and the latter is still repo based but this brought us closer one step for sure! Also oops on the GitHub review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves parts of #189.
I think the rest can follow suit, but I am not sure how to test that it all works. These changes worked out the box based on the implementation description you gave in #189, so I think that will be the case for the remaining entities too.
Merging this unblocks #205.