Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.1 #128

Merged
merged 39 commits into from
Jun 5, 2024
Merged

v2.1.1 #128

merged 39 commits into from
Jun 5, 2024

Conversation

ckmah
Copy link
Collaborator

@ckmah ckmah commented May 14, 2024

Improve robustness and runtime performance after initial SpatialData refactor.

Stability

  • parallelize compute intensive methods
    • bt.tl.flux()
    • bt.tl.analyze_points()
  • re-add test code coverage enable codecov #126
  • downsize test data to speedup tests
  • improve test coverage

Bugs

Copy link

Bento v2.1.1

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 29.39815% with 305 lines in your changes missing coverage. Please review.

Project coverage is 23.71%. Comparing base (ed851d1) to head (8237e35).
Report is 172 commits behind head on master.

Current head 8237e35 differs from pull request most recent head b664b70

Please upload reports for the commit b664b70 to get more accurate results.

Files Patch % Lines
tests/test_ut.py 10.00% 54 Missing ⚠️
bento/tools/_flux.py 10.52% 34 Missing ⚠️
tests/test_flux.py 21.05% 30 Missing ⚠️
bento/plotting/_plotting.py 30.00% 28 Missing ⚠️
bento/tools/_point_features.py 22.22% 21 Missing ⚠️
tests/test_colocation.py 17.39% 19 Missing ⚠️
bento/_utils.py 6.25% 15 Missing ⚠️
tests/test_io.py 28.57% 15 Missing ⚠️
bento/tools/_lp.py 0.00% 14 Missing ⚠️
tests/test_shape_features.py 30.00% 14 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #128       +/-   ##
===========================================
- Coverage   71.84%   23.71%   -48.14%     
===========================================
  Files          35       37        +2     
  Lines        2252     2218       -34     
===========================================
- Hits         1618      526     -1092     
- Misses        634     1692     +1058     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixed the pandas join on points to shapes. Was previously joining points[instance_key] to shape index. Now sets shape index to instance_key first before joining.
@ckmah ckmah marked this pull request as ready for review June 5, 2024 00:22
@ckmah ckmah merged commit 74f1159 into master Jun 5, 2024
9 checks passed
@ckmah ckmah mentioned this pull request Jun 5, 2024
@ckmah ckmah deleted the prep-fixes branch December 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Error. bento.tl.lp() fails if cells are missing nuclei update code coverage check
2 participants