This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
forked from eklitzke/kohlrabi
-
Notifications
You must be signed in to change notification settings - Fork 1
Various upstream changes #2
Open
eklitzke
wants to merge
18
commits into
YelpArchive:master
Choose a base branch
from
eklitzke:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -13,10 +13,12 @@ | |||
{% block body %} | |||
<div class="vgap"><a href="{{uri('/')}}">Back to All Reports</a></div> | |||
<div class="report-label">{{escape(title)}}</div> | |||
<label for="servlet_filter">Servlet Filter: </label><input type="text" id="servlet_filter"/> | |||
<label for="servlet_filter">{{first_column}} Filter: </label><input type="text" id="servlet_filter"/> | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just delete this?
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm the author of the upstream project and think that Yelp should merge my changes to keep up to date; the three changes I pushed today (all minor) are:
requirements.txt
file forpip