-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webhook alerter and docs #3042
base: master
Are you sure you want to change the base?
Add webhook alerter and docs #3042
Conversation
The webhook alerter uses jinja templating engine which allows creating user customizable endpoints and body.
Maybe I need to add Jinja2 installation to requirements.txt and setup.py? |
@nsano-rururu Ah yes! Forgot to add it to the commit. I will do it now. |
I don't usually write in python. So any and all feedback is appreciated! |
Isn't it better to add example_rules as well? Since there is a description about the alert type in README.md, shouldn't it be better to add "webhook" as well?
|
The test code seems to be written in the following file. It seems that travis-ci is running and the test code written in pytest is running when the pull request is made. |
I completely missed the example_rules and Readme. I'll add those. Thanks @nsano-rururu I am currently in middle of writing tests for these as I haven't used pytest before this. |
If you describe the parameter and data type in schema.yaml, an error will appear on the console when the rule runs with a value different from the specified data type, for example, specifying the integer value and specifying the string value. Because the data type of the parameter specified in the rule is different |
Any way you could push this PR to https://github.com/jertel/elastalert2 ? |
Hey @nsano-rururu ! Sure. Let me write up the tests which I had skipped earlier and add create a PR. I'll do it by end of next week. |
The webhook alerter uses jinja templating engine which allows creating user customizable endpoints and body.