-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove star-imports #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋
Thank you for the suggestion, and sorry for the late reply, the repo has been idle for some time, I'm currently fixing and improving things here.
I agree with you that star import should be removed.
Here however I thing it would still make sens and be convenient to directly access to the MidiFile
and container (Note
, ...) classes directly from the main module.
Would you still be interested in applying these last changes, and solve the branch conflicts that appeared as some changes has been made since?
This should hopefully be featured in the next release.
This comment was marked as outdated.
This comment was marked as outdated.
@Natooz Rebased, added exports for MidiFile and all of the classes from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 62.23% 58.34% -3.89%
==========================================
Files 13 12 -1
Lines 789 785 -4
==========================================
- Hits 491 458 -33
- Misses 298 327 +29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful thank you, everything seems good + tests are passing!
The liberal use of star-imports makes
miditoolkit
export quite a lot of names that probably shouldn't be.This removes all of the star imports (so this is a semver major change) in favor of just regular imports from the respective modules.