forked from NVIDIA/spark-rapids
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge jdk steps into one #1
Open
YanxuanLiu
wants to merge
22
commits into
branch-23.06
Choose a base branch
from
matrix_for_jdk_maven_verify
base: branch-23.06
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Signed-off-by: YanxuanLiu <[email protected]>
Verify checks increased runtime since introduction from 2- minutes to 5-7 minutes, mostly due to large dependencies. At least stopping re-compressing them - skip compressing dist jar: 30+ seconds - refactor common maven flags Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]> Co-authored-by: Jason Lowe <[email protected]>
- add Werror to javac args - suppress unavoidable warnings - disable linter for "unclaimed" annotations Fixes NVIDIA#6789 Signed-off-by: Gera Shegalov <[email protected]> Co-authored-by: Jason Lowe <[email protected]>
…VIDIA#8322) Add a null check around host column builders Add a test to avoid future regression Signed-off-by: Raza Jafri <[email protected]> --------- Signed-off-by: Raza Jafri <[email protected]>
…VIDIA#8364) context that could be null Signed-off-by: Thomas Graves <[email protected]>
* Make tables spillable by default --------- Signed-off-by: Alessandro Bellina <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
* Updating tools docs in spark-rapids Signed-off-by: mattahrens <[email protected]> * Adding note in qual tool docs re: dedicated cluster Signed-off-by: mattahrens <[email protected]> * Fix typo in profiling doc for setting Signed-off-by: mattahrens <[email protected]> --------- Signed-off-by: mattahrens <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Signed-off-by: Navin Kumar <[email protected]>
… columns (NVIDIA#8371) Signed-off-by: Robert (Bobby) Evans <[email protected]>
YanxuanLiu
pushed a commit
that referenced
this pull request
Nov 10, 2023
… targets. (NVIDIA#9615) * Bloop updates - require JDK11 in buildall + docs, build bloop for all targets. Signed-off-by: Phil Dakin <[email protected]> * Address PR comments. Signed-off-by: Phil Dakin <[email protected]> * Add a bloopInstall profile (#1) * Add bloopInstall profile Signed-off-by: Gera Shegalov <[email protected]> * Add bloopInstall profile Fixes NVIDIA#9621 Signed-off-by: Gera Shegalov <[email protected]> * add comment for install in scala2.13 Signed-off-by: Gera Shegalov <[email protected]> * simplify Signed-off-by: Gera Shegalov <[email protected]> * undo unrelated Signed-off-by: Gera Shegalov <[email protected]> * Apply suggestions from code review Co-authored-by: PhilDakin <[email protected]> * review 1 Signed-off-by: Gera Shegalov <[email protected]> * Configurable bloopInstall phase Signed-off-by: Gera Shegalov <[email protected]> * move bloop config dir to execution conf Signed-off-by: Gera Shegalov <[email protected]> --------- Signed-off-by: Gera Shegalov <[email protected]> Co-authored-by: PhilDakin <[email protected]> * Propagate bloopInstall profile changes, make config directory overridable from command line. Signed-off-by: Phil Dakin <[email protected]> * Cleanup. Signed-off-by: Phil Dakin <[email protected]> --------- Signed-off-by: Phil Dakin <[email protected]> Signed-off-by: Gera Shegalov <[email protected]> Co-authored-by: Gera Shegalov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.