Fix orch stuch when removing vlan member (sonic-net#3294)

What I did ignore the returned value of setPortPvid()
Yang-Yongzhi · Sep 20, 2024 · ffbe7b0 · ffbe7b0
1 parent 9a6a86f
commit ffbe7b0
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp
@@ -6757,10 +6757,7 @@ bool PortsOrch::removeVlanMember(Port &vlan, Port &port, string end_point_ip)
     /* Restore to default pvid if this port joined this VLAN in untagged mode previously */
     if (sai_tagging_mode == SAI_VLAN_TAGGING_MODE_UNTAGGED)
     {
-        if (!setPortPvid(port, DEFAULT_PORT_VLAN_ID))
-        {
-            return false;
-        }
+        setPortPvid(port, DEFAULT_PORT_VLAN_ID);
     }
 
     m_portList[port.m_alias] = port;