-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement webserver first commit #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nishikawaakira
I got an error that common.js
is missing, am I missing something in my procedure?🤔
(I copied the templates
folder in the feature-webserver
branch before executing the start-server
command.)
fukusuke@fukusukenoMacBook-Air takajo-2.6.0-mac-arm % ls -la ./templates
total 1304
drwxr-xr-x@ 10 fukusuke staff 320 10 14 15:51 .
drwx------@ 10 fukusuke staff 320 10 14 15:49 ..
-rw-r--r--@ 1 fukusuke staff 44659 10 14 15:51 alpinejs.3.14.1.js
-rw-r--r-- 1 fukusuke staff 9391 10 14 15:51 common.js
-rw-r--r--@ 1 fukusuke staff 14552 10 14 15:51 computer_summary.template
-rw-r--r--@ 1 fukusuke staff 18011 10 14 15:51 content.template
-rw-r--r--@ 1 fukusuke staff 83961 10 14 15:51 font-awesome.6.0.css
-rw-r--r--@ 1 fukusuke staff 14943 10 14 15:51 index.template
-rw-r--r--@ 1 fukusuke staff 470394 10 14 15:51 tailwind.3.4.js
drwxr-xr-x@ 4 fukusuke staff 128 9 23 13:14 webfonts
fukusuke@fukusukenoMacBook-Air takajo-2.6.0-mac-arm % ./takajo start-server -s ./html-report.sqlite -p 8089
syncio.nim(767) open
Error: unhandled exception: cannot open: ./src/takajopkg/web/static/js/common.js [IOError]
fukusuke@fukusukenoMacBook-Air takajo-2.6.0-mac-arm %
I would also appreciate it if you could confirm the following two points🙏
|
@nishikawaakira Sorry, can you rename |
@nishikawaakira 横からすみません。 I changed the name from Questions:
P.S. @fukusuket I went ahead and changed the LICENSE to AGPL so we don't need to create another PR for it. |
@YamatoSecurity @fukusuket
It was unnecessary code, so I removed it.
The html-server command also creates a sqlite file, since we need a separate table from the html-report, I think it is better to create it with each command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for implementation! LGTM!!🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nishikawaakira LGTM! Thanks so much!
Web Server functionality has been implemented.
This allows dynamic searches in the GUI.
It also makes links to rules refer to the repository.