Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chg: add supported modifier (contains|cased, startswith|cased, endswith|cased) #782

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chg: add supported modifier (contains|cased, startswith|cased, endswith|cased) #782

merged 2 commits into from
Nov 26, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Nov 26, 2024 •
edited
Loading

What Changed

Added contains|cased, startswith|cased, endswith|cased to markdown.

Test

fukusuke@fukusukenoMacBook-Air supported_modifiers_check % poetry run python supported-modifier.py ../../../sigma ../../../hayabusa-rules ../../doc/SupportedSigmaFieldModifiers.md
2024-11-27 08:48:03,252 - INFO - Starting script execution: supported-modifier.py
2024-11-27 08:48:03,253 - INFO - Starting to process YAML files in directory: ../../../sigma
2024-11-27 08:48:11,902 - INFO - Finished processing YAML files
2024-11-27 08:48:11,903 - INFO - Starting to process YAML files in directory: ../../../hayabusa-rules
2024-11-27 08:48:25,107 - INFO - Finished processing YAML files
2024-11-27 08:48:25,114 - INFO - Markdown report generated and saved to ../../doc/SupportedSigmaFieldModifiers.md
2024-11-27 08:48:25,114 - INFO - Script execution completed in 21.86 seconds
fukusuke@fukusukenoMacBook-Air supported_modifiers_check %

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket self-assigned this Nov 26, 2024
@fukusuket fukusuket added the enhancement New feature or request label Nov 26, 2024
@fukusuket fukusuket marked this pull request as ready for review November 26, 2024 23:49
YamatoSecurity
YamatoSecurity approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 2840764 into main Nov 26, 2024
2 checks passed
@YamatoSecurity YamatoSecurity deleted the add-supported-modifier branch November 26, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

Assignees

@fukusuket fukusuket

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fukusuket @YamatoSecurity