fix: changed rule parse check error option required to true #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YamatoSecurity
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Current behavior
AutoPR was working in check false mode...so I changed the required option to true.
Manually PR (
run csv-timelineexecuted)https://github.com/Yamato-Security/hayabusa-rules/actions/runs/7631251042/job/20788784777
Auto PR(
run csv-timelinenot executed)https://github.com/Yamato-Security/hayabusa-rules/actions/runs/7617479708/job/20746564662
Sorry...I don't know if this will solve the problem, but could you please merge it once?🙏