Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Newsletter Popup Reappearance After User Dismissal #669

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ygowthamr
Copy link
Contributor

@ygowthamr ygowthamr commented Nov 4, 2024

Title: Fix Newsletter Popup Reappearance After User Dismissal

Description

Fix #667

This PR resolves the issue of the newsletter popup reappearing after clicking "No Thanks" by implementing a dismissal flag in cookies/local storage. The popup now checks this flag before displaying, enhancing the user experience by preventing unnecessary prompts.

@YadavAkhileshh
Pls assign me this, Give me label, level.

Copy link

github-actions bot commented Nov 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for alienid ready!

Name Link
🔨 Latest commit 428e6ef
🔍 Latest deploy log https://app.netlify.com/sites/alienid/deploys/6728ee5e371bf9000872f079
😎 Deploy Preview https://deploy-preview-669--alienid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for thunderous-starlight-9c463d ready!

Name Link
🔨 Latest commit 428e6ef
🔍 Latest deploy log https://app.netlify.com/sites/thunderous-starlight-9c463d/deploys/6728ee5e58bd0e0008ba3fb1
😎 Deploy Preview https://deploy-preview-669--thunderous-starlight-9c463d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ygowthamr
Copy link
Contributor Author

@YadavAkhileshh Pls check and merge my PR.

@YadavAkhileshh YadavAkhileshh merged commit d7a8f87 into YadavAkhileshh:main Nov 4, 2024
9 checks passed
Copy link

github-actions bot commented Nov 4, 2024

🎉🎉 Thank you for your contribution! Your PR #669 has been merged! 🎉🎉

@YadavAkhileshh YadavAkhileshh added gssoc-ext New feature or request level2 labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext New feature or request level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Newsletter Popup Reappears on Every Page Load
2 participants