Skip to content

Commit

Permalink
[CHORE] #79 리뷰 코멘트 반영
Browse files Browse the repository at this point in the history
- 링크 공유 구현부 중복 작성부분 제거 (SharedUrlLink 함수 사용)
- 들여쓰기 가독성 개선
  • Loading branch information
l5x5l committed Nov 22, 2024
1 parent 7d76af5 commit 99f35a4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ class RemindRepositoryImpl @Inject constructor(private val remindDataSource: Rem
sort: PokitsSort,
): PokitResult<List<RemindResult>> {
return runCatching {
val response = remindDataSource.getUnreadContents(RemindRequest(size = size, page = page, sort = sort))
val response = remindDataSource.getUnreadContents(
RemindRequest(size = size, page = page, sort = sort)
)
val remindResponse = RemindMapper.mapperToRemind(response)
PokitResult.Success(remindResponse)
}.getOrElse { throwable ->
Expand Down Expand Up @@ -57,7 +59,9 @@ class RemindRepositoryImpl @Inject constructor(private val remindDataSource: Rem
sort: PokitsSort,
): PokitResult<List<RemindResult>> {
return runCatching {
val response = remindDataSource.getBookmarkContents(RemindRequest(size = size, page = page, sort = sort))
val response = remindDataSource.getBookmarkContents(
RemindRequest(size = size, page = page, sort = sort)
)
val remindResponse = RemindMapper.mapperToRemind(response)
PokitResult.Success(remindResponse)
}.getOrElse { throwable ->
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package pokitmons.pokit.linklist

import android.content.Context
import android.content.Intent
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
Expand Down Expand Up @@ -33,6 +32,7 @@ import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import coil.compose.rememberAsyncImagePainter
import pokitmons.pokit.core.feature.model.paging.PagingState
import pokitmons.pokit.core.feature.utils.ShareUrlLink
import pokitmons.pokit.core.ui.components.atom.loading.LoadingProgress
import pokitmons.pokit.core.ui.components.block.linkcard.LinkCard
import pokitmons.pokit.core.ui.components.block.toolbar.Toolbar
Expand Down Expand Up @@ -227,11 +227,7 @@ fun LinkListScreen(
onHideBottomSheet = hideLinkDetailBottomSheet,
show = state.bottomSheetInfo?.type == BottomSheetType.DETAIL,
onClickShareLink = {
val intent = Intent(Intent.ACTION_SEND_MULTIPLE).apply {
type = "text/plain"
putExtra(Intent.EXTRA_TEXT, link.url)
}
context.startActivity(Intent.createChooser(intent, "Pokit"))
ShareUrlLink(context, link.url)
},
onClickModifyLink = {
hideLinkDetailBottomSheet()
Expand Down

0 comments on commit 99f35a4

Please sign in to comment.