Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mz 193 received envelope add #99

Merged
merged 32 commits into from
Jan 28, 2024

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Jan 26, 2024

πŸ’‘ Issue

🌱 Key changes

  • 받은 λ΄‰νˆ¬ 생성 μ„œλ²„ μ—°λ™ν–ˆμŠ΅λ‹ˆλ‹€.

βœ… To Reviewers

πŸ“Έ μŠ€ν¬λ¦°μƒ·

μŠ€ν¬λ¦°μƒ·
νŒŒμΌμ²¨λΆ€λ°”λžŒ
KakaoTalk_Video_2024-01-26-23-19-10.mp4

jinukeu and others added 27 commits January 21, 2024 10:22
# Conflicts:
#	feature/received/src/main/java/com/susu/feature/received/navigation/ReceivedNavigation.kt
…-add' into feature/MZ-193-received-envelope-add
@jinukeu jinukeu self-assigned this Jan 26, 2024
# Conflicts:
#	data/src/main/java/com/susu/data/data/di/RepositoryModule.kt
#	data/src/main/java/com/susu/data/remote/api/LedgerService.kt
#	data/src/main/java/com/susu/data/remote/di/ApiServiceModule.kt
#	feature/navigator/src/main/java/com/susu/feature/navigator/MainNavigator.kt
#	feature/received/src/main/java/com/susu/feature/received/ledgeradd/LedgerAddScreen.kt
#	feature/received/src/main/res/values/strings.xml
@jinukeu
Copy link
Member Author

jinukeu commented Jan 26, 2024

이거 λ΄‰νˆ¬ 생성 api 응닡값이 변경될 μ˜ˆμ •μ΄λΌ ... κ·Έκ±°κΉŒμ§€ ν•΄κ²°ν•˜κ³  Mergeν•˜κ² μŠ΅λ‹ˆλ‹€.
생각보닀 양이 κ½€ λ˜λ„€μš” ... ν•˜ν•˜ ... λ¨Όμ € μ½”λ“œ 리뷰 ν•΄μ£Όμ‹œλ©΄ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€

Copy link
Member

@yangsooplus yangsooplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ½”λ“œμ–‘μ΄ λ§Žμ•„μ„œ μ½”λ“œλŠ” 훑어보듯 κ°€λ³κ²Œ λ³΄μ•˜κ³  μž‘λ™μ‹œμΌœμ„œ μ‹€μ œ λ™μž‘μ΄λž‘ 둜그 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€~
λ‚ μ§œ 선택 λ°”ν…€μ‹œνŠΈμͺ½λ§Œ 고쳐주세여 (μž₯λΆ€ λ‚ μ§œ 선택도 λ˜‘κ°™λ”λΌκ³ μš”)

@@ -22,7 +24,7 @@ object ApiServiceModule {

@Singleton
@Provides
fun provideUserService(retrofit: Retrofit): AuthService {
fun provideAuthService(retrofit: Retrofit): AuthService {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„μ•— 이름이 덜 λ°”λ€κ²Œ μžˆμ—ˆκ΅°μš” κ³ μ³μ£Όμ…”μ„œ 감삼닀

Comment on lines +43 to +55
fun getFriendList(search: String) = viewModelScope.launch {
if (search.isEmpty()) return@launch
if (currentState.isSelectedFriend) return@launch

searchFriendUseCase(name = search)
.onSuccess {
intent {
copy(
friendList = it.toPersistentList(),
)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

친ꡬ 검색 μ‹œ λ‘œλ”©μƒνƒœμ™€ λ„€νŠΈμ›Œν¬ μ—λŸ¬ μ‹œμ˜ μ²˜λ¦¬κ°€ ν•„μš”ν•΄λ³΄μž…λ‹ˆλ‹€!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ μš”κ±΄ μΌλΆ€λŸ¬ μ•ˆν–ˆμ–΄μš”~!
친ꡬ 검색 apiλŠ” 맀우 자주 호좜되기 λ•Œλ¬Έμ— κ·Έλ•Œλ§ˆλ‹€ λ‘œλ”© μƒνƒœμ™€ μ—λŸ¬ 처리λ₯Ό ν•˜κ²Œ 되면 였히렀 μ•ˆμ’‹λ‹€κ³  μƒκ°ν–ˆμŠ΅λ‹ˆλ‹€!

λ‹€λ₯Έ μ•±μ—μ„œλ„ 보톡 처리 μ•ˆν•˜λ”λΌκ΅¬μš”~!

initialMonth = uiState.date?.monthValue ?: currentDate.monthValue,
initialDay = uiState.date?.dayOfMonth ?: currentDate.dayOfMonth,
maximumContainerHeight = 346.dp,
onDismissRequest = { _, _, _ -> onDismissDateBottomSheet() },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KakaoTalk_Video_2024-01-27-22-01-31.mp4

λ°”ν…€μ‹œνŠΈ dismiss μ‹œμ—λ„ μ§€μ •λœ λ‚ μ§œκ°€ μ„ νƒλ˜λ„λ‘ μˆ˜μ •ν•΄μ£Όμ„Έμš”! 였늘 λ‚ μ§œλ₯Ό μž…λ ₯ν•˜κ³  싢을 λ•Œ ν•œλ²ˆ μŠ¬λΌμ΄λ“œλ₯Ό ν•˜μ§€ μ•ŠμœΌλ©΄ μ„ νƒλ˜μ§€ μ•ŠλŠ”κ²Œ λΆˆνŽΈν•  것 κ°™λ„€μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ledgerList = newList,
showEmptyLedger = newList.isEmpty(),
)
}
}

fun addLedgerIfNeed(ledger: String?) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 ν•¨μˆ˜, μ–΄λŠ μƒν™©μ—μ„œ μ‚¬μš©ν•˜λŠ” κ±΄κ°€μš”?
IfNeed에 ν•΄λ‹Ήν•˜λŠ” 상황이 κΆκΈˆν•΄μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μž₯λΆ€ μΆ”κ°€λ₯Ό ν•˜κ²Œλ˜λ©΄, μΆ”κ°€λœ μž₯λΆ€λ₯Ό λ°›μ•„μš” ν™”λ©΄μœΌλ‘œ λ„˜κΈ°κ²Œ λ©λ‹ˆλ‹€.

μΆ”κ°€λœ μž₯λΆ€κ°€

  1. 필터링에 걸리지 μ•ŠλŠ”λ‹€.
  2. λ°›μ•„μš” 화면에 μ—†λ‹€.
  3. 기타 λ“±λ“± ...

의 경우 λ°›μ•„μš” 화면이 가지고 μžˆλŠ” μž₯λΆ€ λ¦¬μŠ€νŠΈμ— μΆ”κ°€λœ μž₯λΆ€λ₯Ό μ‚½μž…ν•©λ‹ˆλ‹€~!

말둜 μ„€λͺ…ν•˜κΈ° μ–΄λ ΅λ„€μš” ... ν˜Ήμ‹œ 이해가 μ•ˆλ˜λŠ” 뢀뢄이 μžˆλ‹€λ©΄ μ–Όλ§ˆλ“ μ§€ 질문 μ£Όμ„Έμš”!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으음 1번의 κ²½μš°λŠ” μž₯λΆ€ λͺ©λ‘μ— ν•„ν„°κ°€ κ±Έλ €μžˆμ„ λ•Œ 필터에 μΆ©μ‘±ν•˜μ§€ μ•ŠλŠ” μž₯λΆ€κ°€ μƒμ„±λ˜μ—ˆμ„ κ²½μš°μΈκ°€μš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„€ λ§žμ•„μš”~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ν•˜ ν™•μΈν–ˆμŠ΄λ‹€

@jinukeu jinukeu requested a review from yangsooplus January 27, 2024 15:36
@jinukeu jinukeu merged commit a82a1ad into develop Jan 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 받은 λ΄‰νˆ¬ 생성 μ„œλ²„ 연동
3 participants