-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mz 193 received envelope add #99
Conversation
# Conflicts: # feature/received/src/main/java/com/susu/feature/received/navigation/ReceivedNavigation.kt
β¦-add' into feature/MZ-193-received-envelope-add
# Conflicts: # data/src/main/java/com/susu/data/data/di/RepositoryModule.kt # data/src/main/java/com/susu/data/remote/api/LedgerService.kt # data/src/main/java/com/susu/data/remote/di/ApiServiceModule.kt # feature/navigator/src/main/java/com/susu/feature/navigator/MainNavigator.kt # feature/received/src/main/java/com/susu/feature/received/ledgeradd/LedgerAddScreen.kt # feature/received/src/main/res/values/strings.xml
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ½λμμ΄ λ§μμ μ½λλ νμ΄λ³΄λ― κ°λ³κ² 보μκ³ μλμμΌμ μ€μ λμμ΄λ λ‘κ·Έ νμΈνμ΅λλ€~
λ μ§ μ ν λ°ν
μνΈμͺ½λ§ κ³ μ³μ£ΌμΈμ¬ (μ₯λΆ λ μ§ μ νλ λκ°λλΌκ³ μ)
@@ -22,7 +24,7 @@ object ApiServiceModule { | |||
|
|||
@Singleton | |||
@Provides | |||
fun provideUserService(retrofit: Retrofit): AuthService { | |||
fun provideAuthService(retrofit: Retrofit): AuthService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μμ μ΄λ¦μ΄ λ λ°λκ² μμκ΅°μ κ³ μ³μ£Όμ μ κ°μΌλ€
fun getFriendList(search: String) = viewModelScope.launch { | ||
if (search.isEmpty()) return@launch | ||
if (currentState.isSelectedFriend) return@launch | ||
|
||
searchFriendUseCase(name = search) | ||
.onSuccess { | ||
intent { | ||
copy( | ||
friendList = it.toPersistentList(), | ||
) | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μΉκ΅¬ κ²μ μ λ‘λ©μνμ λ€νΈμν¬ μλ¬ μμ μ²λ¦¬κ° νμν΄λ³΄μ λλ€!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ μ건 μΌλΆλ¬ μνμ΄μ~!
μΉκ΅¬ κ²μ apiλ λ§€μ° μμ£Ό νΈμΆλκΈ° λλ¬Έμ κ·Έλλ§λ€ λ‘λ© μνμ μλ¬ μ²λ¦¬λ₯Ό νκ² λλ©΄ μ€νλ € μμ’λ€κ³ μκ°νμ΅λλ€!
λ€λ₯Έ μ±μμλ λ³΄ν΅ μ²λ¦¬ μνλλΌκ΅¬μ~!
initialMonth = uiState.date?.monthValue ?: currentDate.monthValue, | ||
initialDay = uiState.date?.dayOfMonth ?: currentDate.dayOfMonth, | ||
maximumContainerHeight = 346.dp, | ||
onDismissRequest = { _, _, _ -> onDismissDateBottomSheet() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KakaoTalk_Video_2024-01-27-22-01-31.mp4
λ°ν μνΈ dismiss μμλ μ§μ λ λ μ§κ° μ νλλλ‘ μμ ν΄μ£ΌμΈμ! μ€λ λ μ§λ₯Ό μ λ ₯νκ³ μΆμ λ νλ² μ¬λΌμ΄λλ₯Ό νμ§ μμΌλ©΄ μ νλμ§ μλκ² λΆνΈν κ² κ°λ€μ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ledgerList = newList, | ||
showEmptyLedger = newList.isEmpty(), | ||
) | ||
} | ||
} | ||
|
||
fun addLedgerIfNeed(ledger: String?) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄ ν¨μ, μ΄λ μν©μμ μ¬μ©νλ 건κ°μ?
IfNeedμ ν΄λΉνλ μν©μ΄ κΆκΈν΄μ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ₯λΆ μΆκ°λ₯Ό νκ²λλ©΄, μΆκ°λ μ₯λΆ
λ₯Ό λ°μμ νλ©΄
μΌλ‘ λκΈ°κ² λ©λλ€.
μΆκ°λ μ₯λΆκ°
- νν°λ§μ κ±Έλ¦¬μ§ μλλ€.
- λ°μμ νλ©΄μ μλ€.
- κΈ°ν λ±λ± ...
μ κ²½μ° λ°μμ νλ©΄
μ΄ κ°μ§κ³ μλ μ₯λΆ λ¦¬μ€νΈ
μ μΆκ°λ μ₯λΆ
λ₯Ό μ½μ
ν©λλ€~!
λ§λ‘ μ€λͺ νκΈ° μ΄λ ΅λ€μ ... νΉμ μ΄ν΄κ° μλλ λΆλΆμ΄ μλ€λ©΄ μΌλ§λ μ§ μ§λ¬Έ μ£ΌμΈμ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μΌμ 1λ²μ κ²½μ°λ μ₯λΆ λͺ©λ‘μ νν°κ° κ±Έλ €μμ λ νν°μ μΆ©μ‘±νμ§ μλ μ₯λΆκ° μμ±λμμ κ²½μ°μΈκ°μ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ€ λ§μμ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μν νμΈνμ΄λ€
π‘ Issue
π± Key changes
β To Reviewers
πΈ μ€ν¬λ¦°μ·
KakaoTalk_Video_2024-01-26-23-19-10.mp4