Feature/mz 199 마이페이지 - 내정보 편집, 앱 버전, 개인정보처리방침 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
approved these changes
Jan 25, 2024
Comment on lines
251
to
253
| if (packageInfo != null) { | ||
| return packageInfo.versionName | ||
| } |
There was a problem hiding this comment.
엇 맞네요
긁어오고 확인 안한거 딱 걸렸네요 머슥
Comment on lines
245
to
258
| private fun getAppVersion(context: Context): String { | ||
| try { | ||
| val packageInfo = context.packageManager.getPackageInfo( | ||
| context.packageName, 0, | ||
| ) | ||
|
|
||
| if (packageInfo != null) { | ||
| return packageInfo.versionName | ||
| } | ||
| } catch (e: Exception) { | ||
| e.printStackTrace() | ||
| } | ||
| return "" | ||
| } |
There was a problem hiding this comment.
Suggested change
| private fun getAppVersion(context: Context): String { | |
| try { | |
| val packageInfo = context.packageManager.getPackageInfo( | |
| context.packageName, 0, | |
| ) | |
| if (packageInfo != null) { | |
| return packageInfo.versionName | |
| } | |
| } catch (e: Exception) { | |
| e.printStackTrace() | |
| } | |
| return "" | |
| } | |
| private fun getAppVersion(context: Context): String = runCatching { | |
| val packageInfo = context.packageManager.getPackageInfo( | |
| context.packageName, 0, | |
| ) | |
| packageInfo.versionName | |
| }.getOrNull() ?: "" |
모든 예외를 catch 할거면 runCatching이 더 가독성이 좋을거같아요
또 이 함수는 리컴포지션이 발생할 때마다 실행되서 별로인거같습니다. remember 쓰는거 어때요?
There was a problem hiding this comment.
|
개인정보처리방침까지 포함시켰습니다! |
yangsooplus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
✅ To Reviewers
개인정보처리방침은 노션 웹뷰 이슈로 추후 따로 작업 예정📸 스크린샷
-.mp4