Feature/mz 145 엑셀 파일 다운로드 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
approved these changes
Jan 21, 2024
| private val tokenRepository: TokenRepository, | ||
| ) : ExcelRepository { | ||
| override suspend fun downloadEnvelopExcel(): Long { | ||
| val token = tokenRepository.getAccessToken().firstOrNull() ?: return -1L |
There was a problem hiding this comment.
null인 경우에는 UnknownException을 throw하는게 더 좋을거같아요!
There was a problem hiding this comment.
그러네요 여기서 -1L을 리턴해버리면 저장된 토큰이 없는 오류와 다운로드 중 발생한 오류인지 구분할 수 없어서 Exception throw 하는게 맞다고 생각이 드네여
반영했습니다~!
d86f0d7
Comment on lines
+58
to
+74
| broadcastReceiver = object : BroadcastReceiver() { | ||
| override fun onReceive(context: Context, intent: Intent?) { | ||
| if (intent?.action == INTENT_ACTION_DOWNLOAD_COMPLETE) { | ||
| val id = intent.getLongExtra(DownloadManager.EXTRA_DOWNLOAD_ID, -1L) | ||
| if (id != -1L) { | ||
| viewModel.onShowSnackbar(SnackbarToken(message = context.getString(com.susu.feature.mypage.R.string.snackbar_success_export))) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| ContextCompat.registerReceiver( | ||
| this, | ||
| broadcastReceiver, | ||
| IntentFilter(DownloadManager.ACTION_DOWNLOAD_COMPLETE), | ||
| ContextCompat.RECEIVER_EXPORTED, | ||
| ) |
There was a problem hiding this comment.
MainActivity의 onDestry()에서 BroadcastReceiver 등록을 해제하기 위해 여기에 위치해있습니당
configuration change가 일어나면 리시버가 해제되지 않은 상태에서 새 리시버가 중복으로 등록될 위험이 있어서요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
DownloadManager를 이용한 파일 다운로드BroadcastReceiver를 등록하여 다운로드 완료시 스낵바 노출📸 스크린샷
default.mp4