Feature/mz 182 ledger add #79
Conversation
# Conflicts: # core/ui/src/main/res/values/strings.xml # feature/received/src/main/res/values/strings.xml
| @@ -114,9 +114,9 @@ fun SusuDatePickerBottomSheet( | |||
| @OptIn(ExperimentalMaterial3Api::class) | |||
| @Composable | |||
| fun SusuLimitDatePickerBottomSheet( | |||
There was a problem hiding this comment.
λ°ν
μνΈμμ 리μ€νΈμ 보μ΄λ λ μ§λ₯Ό λλ¬μλ μ νν μ μλλ‘ μμ ν΄μΌ ν κ² κ°λλΌκ³ μ..
νμ νΌμ³ λΉ¨λ λλ΄κ³ μΆκ°ν΄λ³΄λ €κ³ ν©λλ€~
| import java.time.LocalDateTime | ||
|
|
||
| data class DateState( | ||
| val name: String = "", |
There was a problem hiding this comment.
μ΄ name νλκ° NateStateμ name κ³Ό κ°μ λ°μ΄ν°λ₯Ό λνλ΄λκ² λ§μ§μ?
NameViewModelμμ SideEffectμμ DateStateμ nameμ μ
λ°μ΄νΈ νλ κ³Όμ μ΄ μλλ°, DateStateμ NameState, DateViewModelκ³Ό NameViewModelλ₯Ό νλλ‘ ν©μΉλ건 μ΄λμ?
Stateκ° ν¬κ³ 볡μ‘ν΄μ§κΈ° vs State κ°κ²°νκ² λλκ³ κ΄κ³κ° 볡μ‘ν΄μ§κΈ° κ²°κ΅ μ‘°μΌλͺ¨μ¬ κ°κΈ΄νλ°.. μΆν μ¬μ κ° μκΈ°λ©΄ μ΄λ° 볡μ‘ν Stateλ₯Ό μ΄λ»κ² κ΄λ¦¬νλ©΄ μ’μμ§ μ΄μΌκΈ°ν΄λ³΄λ©΄ μ’μκ² κ°μμ~!
There was a problem hiding this comment.
Stateλ₯Ό νλλ‘ ν©μΉκ²λλ©΄ κ°λ³μ μΌλ‘ μ¬νμ©μ΄ λΆκ°λ₯νκΈ° λλ¬Έμ λλ΄μ΄μ
νΌκ·Έλ§ λμμΈμ 보μμ λ, μμ Contentλ€μ μ¬νμ©νκ±°λ λ³κ²½νκΈ° μ½κ² ꡬννκΈ° μν΄ μ½λμ μμ΄ λ§μμ§λλΌλ λΆλ¦¬νλκ² μ’λ€κ΅¬ νλ¨νμ΄μ!
| private var selectedCategory: Category? = null | ||
| private var name: String = "" | ||
| private var startAt: LocalDateTime? = null | ||
| private var endAt: LocalDateTime? = null |
There was a problem hiding this comment.
μ΄ μΉκ΅¬λ€ κ²°κ΅ Stateμ²λΌ μ¬μ©νκ³ μμ΄ λ³΄μ΄λλ°, LedgerAddStateμμ κ΄λ¦¬νλ κ²κ³Ό μ¬κΈ°μ κ΄λ¦¬νλ κ²κ³Ό μ°¨μ΄κ° μλμ?
There was a problem hiding this comment.
LedgerAddScreenμ μνκ° μλ, μλ²μ μ μ‘νκΈ° μν λ°μ΄ν°μ΄κΈ° λλ¬Έμ Stateλ‘ κ΄λ¦¬νμ§ μμμ΅λλ€!
|
μμ§λ μ½λ©νΈ λ³΄κ³ λ€μ PR 보λ μ€κ³κ° μλͺ»λμλλΌκ΅¬μ. |
π‘ Issue
π± Key changes
β To Reviewers
μ¬μ§μ 보μ΄λ νμ 1, νμ 2 λΆλ¦¬λ μμ§ λͺ»νμ΄μ. (μλ² μμ μ΄ μκ°λ³΄λ€ μ€λ 걸리λ€μ)
λ€λ₯Έ PRμμ μ μ©νκ² μ΅λλ€.
πΈ μ€ν¬λ¦°μ·
KakaoTalk_Video_2024-01-21-10-34-06.mp4