Feature/mz 174 add ledger UI textfield button focus state #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
commented
Jan 11, 2024
Comment on lines
19
to
21
| @Composable | ||
| fun InputDateScreen() { | ||
| Column( |
There was a problem hiding this comment.
요 Screen은 디자인이 변경될거같아서 뼈대만 구현했습니다!
코드 리뷰 스킵해주세요!
There was a problem hiding this comment.
얘 그냥 지금하고 작업 끝나면 코멘트 남길게요~
| modifier = Modifier.fillMaxWidth(), | ||
| color = GhostButtonColor.Black, | ||
| style = MediumButtonStyle.height60, | ||
| text = "결혼식", |
There was a problem hiding this comment.
결혼식, 돌잔치, 장례식, 생일 기념일은 서버에서 받아올거라서 string res 추출 안했어유
yangsooplus
reviewed
Jan 11, 2024
Comment on lines
75
to
85
| HorizontalPager( | ||
| modifier = Modifier.weight(1f), | ||
| state = pagerState, | ||
| userScrollEnabled = false, | ||
| ) { page -> | ||
| when (LedgerAddPage.entries[page]) { | ||
| LedgerAddPage.CATEGORY -> SelectCategoryScreen() | ||
| LedgerAddPage.NAME -> InputNameScreen() | ||
| LedgerAddPage.DATE -> InputDateScreen() | ||
| } | ||
| } |
There was a problem hiding this comment.
어머 Pager로 구현하셨군요 저는 AnimatedContent로 구현했는데, Pager에서 애니메이션 효과를 변경할 수 있나요?
웬만하면 애니메이션만 맞춰서 수정사항을 최소화하면 좋을거 같아서요!
There was a problem hiding this comment.
수진님 PR 보고 왔는데요
AnimatedContent가 더 좋아보이네요~!
Pager를 사용하게되면 rememberPagerState를 만드는게 상태가 분리된다는 느낌이 들어 별로였거든요!
제가 AnimatedContent로 수정하겠습니다! 수정 후 re-request 할게요~
@syb8200 저희 Pager말고 AnimatedContent를 사용하는 쪽으로 갈게요!
There was a problem hiding this comment.
넵~ 🙆♀️
애니메이션도 이쁘게 넣을 수 있어서 오히려좋아입니다~~
Comment on lines
+191
to
+194
| when { | ||
| isFocused.not() -> (unFocusedBackgroundColor to unFocusedTextColor) | ||
| isSaved -> (savedBackgroundColor to savedTextColor) | ||
| else -> (editBackgroundColor to editTextColor) |
# Conflicts: # core/ui/src/main/res/values/strings.xml
|
코드 리뷰 부탁드릴게요~! |
yangsooplus
approved these changes
Jan 12, 2024
Comment on lines
+8
to
+21
| fun <S> AnimatedContentTransitionScope<S>.susuDefaultAnimatedContentTransitionSpec(leftDirectionCondition: Boolean): ContentTransform { | ||
| val direction = if (leftDirectionCondition) { | ||
| AnimatedContentTransitionScope.SlideDirection.Left | ||
| } else { | ||
| AnimatedContentTransitionScope.SlideDirection.Right | ||
| } | ||
| return slideIntoContainer( | ||
| towards = direction, | ||
| animationSpec = tween(500), | ||
| ) togetherWith slideOutOfContainer( | ||
| towards = direction, | ||
| animationSpec = tween(500), | ||
| ) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
✅ To Reviewers
서버 연동하면서 건드릴게 많아서 동작은 최소한으로 구현했습니다.
UI 위주로 코드리뷰 부탁드릴게요!
📸 스크린샷