Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ sent statistics GA #158

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Feature/ sent statistics GA #158

merged 4 commits into from
Feb 19, 2024

Conversation

yangsooplus
Copy link
Member

๐Ÿ’ก Issue

๐ŸŒฑ Key changes

  • ๋ณด๋‚ด์š”

    • ์ •๋ ฌ
      • ์ •๋ ฌ ๋ฒ„ํŠผ ํด๋ฆญ ์ˆ˜
      • ์ตœ์‹  ์ˆœ, ์˜ค๋ž˜๋œ ์ˆœ, ๊ธˆ์•ก ๋†’์€ ์ˆœ, ๊ธˆ์•ก ๋‚ฎ์€ ์ˆœ
    • ํ•„ํ„ฐ
      • ํ•„ํ„ฐ ๋ฒ„ํŠผ ํด๋ฆญ ์ˆ˜
      • ์นœ๊ตฌ ๋ฒ„ํŠผ ํด๋ฆญ ์ˆ˜
      • ๊ธˆ์•ก ์Šฌ๋ผ์ด๋” ํด๋ฆญ ์ˆ˜
      • ์ ์šฉ ๋ฒ„ํŠผ ํด๋ฆญ ์ˆ˜
    • ๋ณด๋‚ด์š” ์ธ๋ฌผ ๋ด‰ํˆฌ ์ „์ฒด๋ณด๊ธฐ ๋ฒ„ํŠผ
      • ํด๋ฆญ ์ˆ˜
    • ๋ด‰ํˆฌ/์žฅ๋ถ€ ์ƒ์„ฑ ํŽ˜์ด์ง€
      • ๋‹จ๊ณ„ ๋ณ„ ๋‹ค์Œ ๋ฒ„ํŠผ ํด๋ฆญ ์ˆ˜
      • ๋‹จ๊ณ„ ๋ณ„ Back ๋ฒ„ํŠผ ํด๋ฆญ ์ˆ˜

  • ํ†ต๊ณ„

    • ๋‚˜์˜ ์ˆ˜์ˆ˜/์ˆ˜์ˆ˜ ํ‰๊ท  ํ™”๋ฉด ์ฒด๋ฅ˜์‹œ๊ฐ„
      • ์–ด๋–ค ํ†ต๊ณ„์— ๋” ๊ด€์‹ฌ์ด ์žˆ๋Š” ์ง€
    • ์ˆ˜์ˆ˜ ํ‰๊ท  - ๋“œ๋กญ ๋‹ค์šด ์˜ต์…˜ ๋ณ„ ํด๋ฆญ ์ˆ˜
      • ์–ด๋–ค ์—ฐ๋ น/๊ด€๊ณ„/๊ฒฝ์กฐ์‚ฌ์— ๊ด€์‹ฌ์„ ๋ณด์ด๋Š” ์ง€

@yangsooplus yangsooplus requested a review from jinukeu February 19, 2024 10:58
@yangsooplus yangsooplus self-assigned this Feb 19, 2024
@yangsooplus yangsooplus marked this pull request as ready for review February 19, 2024 10:58
jinukeu
jinukeu reviewed Feb 19, 2024
View reviewed changes
feature/sent/src/main/java/com/susu/feature/envelopefilter/EnvelopeFilterScreen.kt
Comment on lines +105 to +117
LaunchedEffect(key1 = uiState.fromAmount, key2 = uiState.toAmount) {
snapshotFlow { uiState.fromAmount }
.debounce(1000L)
.collect {
viewModel.logSliderClickEvent()
}

snapshotFlow { uiState.toAmount }
.debounce(1000L)
.collect {
viewModel.logSliderClickEvent()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slider ๋‚ด๋ถ€์— onValueChangeFinished ์žˆ๋Š”๋ฐ ๊ทธ๊ฑธ๋กœ ga ๊ธฐ๋กํ•˜๋Š”๊ฒŒ ๋” ์ •ํ™•ํ• ๊ฑฐ๊ฐ™์•„์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฒ˜์Œ์— ๊ทธ ๋ฐฉ์‹์œผ๋กœ ํ–ˆ๋”๋‹ˆ ์Šฌ๋ผ์ด๋”๊ฐ€ ๋ฒ„๋ฒ„๋ฒ„๋ฒ„๋ฒ„๋ฒ„๋ฒ… ํ•˜๊ฒŒ ๋™์ž‘ํ•˜๋”๋ผ๊ณ ์š”,,,,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—‡ onValueChange ๋ง๊ตฌ onValueChangeFinished ๋งž๋‚˜์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต............. ์ด๋ ‡๊ฒŒ ๋˜๋”๋ผ๊ณ ์š”

finish.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธ€์ฟค์š” ... ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค

jinukeu
jinukeu reviewed Feb 19, 2024
View reviewed changes
...e/statistics/src/main/java/com/susu/feature/statistics/content/susu/SusuStatisticsContent.kt Outdated
Comment on lines 85 to 91
FirebaseAnalytics.getInstance(context).logEvent(
FirebaseAnalytics.Event.SELECT_CONTENT,
bundleOf(
FirebaseAnalytics.Param.CONTENT_TYPE to "statistics_category",
FirebaseAnalytics.Param.VALUE to sideEffect.category,
),
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

GA์—์„œ VALUE ๊ฐ’ ์–ด์ผ€ ๋ณด์‹œ๋Š”์ง€ ์•„์‹œ๋‚˜์š”?
GA ๋‹ฌ๋ฉด์„œ ์ด๊ณณ ์ €๊ณณ ์ฐพ์•„๋ดค๋Š”๋ฐ CONTENT_TYPE๋งŒ ํ™•์ธ๊ฐ€๋Šฅํ–ˆ์Šต๋‹ˆ๋‹ค ใ…œใ…œ (์ œ๊ฐ€ ๋ชป์ฐพ์€ ๊ฑธ์ˆ˜๋„ ...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-02-19 แ„‹แ…ฉแ„’แ…ฎ 8 23 59

์ด๊ณณ์— ํ‘œ์‹œ๋  ์ค„ ์•Œ๊ณ  ๋„ฃ์—ˆ๋Š”๋ฐ, ํ™•์ธ์ด ์•ˆ๋์—ˆ์–ด์„œ ์ง€๋‚œ PR์— ํฌํ•จ๋˜์ง€ ์•Š์•˜๋˜๊ฑฐ์˜€๊ตฐ์—ฌ
์œผ์Œ,, ์—ฌ๊ธฐ Solution 3์„ ๋ณด๋ฉด Long, Double Value๋งŒ ์ง‘๊ณ„๋œ๋‹ค๋Š” ๋ง์ด ์žˆ๋„ค์š”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์–ด์ฉ์ง€ ... GA ๋„˜ ์–ด๋ ต๋„ค์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ๋‹จ CONTENT_TYPE ํŒŒ๋ผ๋ฏธํ„ฐ์— ๊ฐ’์„ ํฌํ•จ์‹œํ‚ค๋Š” ์‹์œผ๋กœ ์ˆ˜์ •ํ• ๊ฒŒ์š”!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: ์ˆ˜์ˆ˜ํ†ต๊ณ„ Param.VALUE ์ œ๊ฑฐ ํ›„ CONTENT_TYPE์— ํฌํ•จ

@yangsooplus yangsooplus merged commit 18ac2e5 into develop Feb 19, 2024
1 check passed
@yangsooplus yangsooplus deleted the feature/GA-sent-statistics branch February 19, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinukeu jinukeu jinukeu approved these changes

Assignees

@yangsooplus yangsooplus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] GA - ๋ณด๋‚ด์š”, ํ†ต๊ณ„
2 participants
@yangsooplus @jinukeu