Feature/mz 130 수수 통계 #120
Merged
Feature/mz 130 수수 통계 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
동작은 하지 않습니다
jinukeu
approved these changes
Feb 2, 2024
Comment on lines
109
to
133
| title = "지금 평균 수수 보기", | ||
| age = stringResource(id = R.string.word_age_unit, uiState.age.num), | ||
| money = uiState.susuStatistics.averageSent, | ||
| relationship = uiState.relationship.relation, | ||
| category = uiState.category.name, | ||
| onAgeClick = onClickAge, | ||
| onCategoryClick = onClickCategory, | ||
| onRelationshipClick = onClickRelationship, | ||
| ) | ||
| StatisticsHorizontalItem( | ||
| title = "관계 별 평균 수수", | ||
| name = uiState.susuStatistics.averageRelationship.title, | ||
| money = uiState.susuStatistics.averageRelationship.value, | ||
| isActive = !isBlind, | ||
| ) | ||
| StatisticsHorizontalItem( | ||
| title = "경조사 카테고리 별 평균 수수", | ||
| name = uiState.susuStatistics.averageCategory.title, | ||
| money = uiState.susuStatistics.averageCategory.value, | ||
| isActive = !isBlind, | ||
| ) | ||
|
|
||
| RecentSpentGraph( | ||
| isActive = !isBlind, | ||
| graphTitle = "올해 쓴 금액", |
There was a problem hiding this comment.
잠결에 깜박했내여 ㅎㅎ;
| val categoryConfigResult = getCategoryConfigUseCase() | ||
| val relationshipConfigResult = getRelationShipConfigListUseCase() | ||
|
|
||
| if (categoryConfigResult.isSuccess && relationshipConfigResult.isSuccess) { |
There was a problem hiding this comment.
Fail인 경우도 추가하면 좋을거같아요
만약 실패했다면 아무런 통계 화면이 안나올 것 같은데 에러 메세지가 없다면 UX 저하가 발생해서요~
There was a problem hiding this comment.
실패한 쪽의 Exception을 스낵바로 띄우로독 했습니다
There was a problem hiding this comment.
는 디폴트 Throwable 하나 넣었더니 cicd에 걸렷네요 다시 수정할게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
AnimatedCounterText라는 숫자 애니메이션 Text 컴포넌트를 추가했습니다.✅ To Reviewers
📸 스크린샷
default.mp4