Feature/mz 197 received envelop edit delete, 장부 그룹핑 제거 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsooplus
reviewed
Jan 31, 2024
Comment on lines
+118
to
+125
| category = if (categoryId != null) { | ||
| CategoryRequest( | ||
| id = categoryId, | ||
| customCategory = customCategory, | ||
| ) | ||
| } else { | ||
| null | ||
| }, |
There was a problem hiding this comment.
customCategory가 아니라 Category 자체가 null이어도 되나요?
There was a problem hiding this comment.
받은 봉투에서는 Category를 입력받지 않아서 괜찮아요
Comment on lines
+31
to
+35
| private var isFirstVisited: Boolean = true | ||
|
|
||
| fun initData() = viewModelScope.launch { | ||
| if (isFirstVisited.not()) return@launch | ||
| isFirstVisited = false |
There was a problem hiding this comment.
isFirstVisited가 필요하게 된 경위가 궁금합니다
There was a problem hiding this comment.
isFirstVisited가 없으면 초기 컴포지션이 일어날 때마다 아래의 로직이 수행돼요.
isFirstVisited가 없으면 디바이스 화면을 껏다가 키면 로직이 매번 재수행됩니다.
Comment on lines
+59
to
+62
| fun updateEnvelopeIfNeed(envelopeUri: String?) = intent { | ||
| val envelope = envelopeUri?.let { | ||
| Json.decodeFromUri<Envelope>(it) | ||
| } ?: return@intent this |
There was a problem hiding this comment.
여기도 IfNeed라는 상황이 어떤 상황인지 궁금합니당
There was a problem hiding this comment.
장부 상세 화면이 navBackEntry에서 envelopeUri를 넘겨받았다면, 해당 envelop를 업데이트 해주는 상황이에요
yangsooplus
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
✅ To Reviewers
친구 관련 요소를 편집하면 크래시가 발생하는데, 서버 문제여서 수정 요청해놨습니다.
📸 스크린샷
KakaoTalk_Video_2024-01-31-15-35-40.mp4