Feature/mz 219 check dialog 컴포넌트 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
🌱 Key changes
CheckCircle을 디자인시스템 컴포넌트로 분리했습니다.SusuCheckedDialog컴포넌트 추가DialogToken프로퍼티 추가✅ To Reviewers
DialogToken과 별개의 클래스를 만드려다가, 공통되는 파라미터가 많고 추가되는 파라미터가 3개 뿐이라 일부 프로퍼티를 추가하는 방법으로 구현했습니다.DialogToken에 추가된 파라미터는 kdoc으로 주석을 달아놓았습니다.DialogToken에 마우스 대면 떠요.📸 스크린샷
default.mp4